Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8331959: Update PKCS#11 Cryptographic Token Interface to v3.1 #2979

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vieiro
Copy link
Contributor

@vieiro vieiro commented Dec 20, 2024

Clean backport of JDK-8331959 for parity with Oracle's 11.0.27.
This adds some new constants and typedefs, and minor formatting of the license file.
Passes tier1 tests on Linux.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8331959 needs maintainer approval

Issue

  • JDK-8331959: Update PKCS#11 Cryptographic Token Interface to v3.1 (Enhancement - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2979/head:pull/2979
$ git checkout pull/2979

Update a local copy of the PR:
$ git checkout pull/2979
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2979/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2979

View PR using the GUI difftool:
$ git pr show -t 2979

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2979.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 20, 2024

👋 Welcome back vieiro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 20, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport e3b26387a3aa24640729086166fa52b6c5a6ea92 8331959: Update PKCS#11 Cryptographic Token Interface to v3.1 Dec 20, 2024
@openjdk
Copy link

openjdk bot commented Dec 20, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 20, 2024

⚠️ @vieiro This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 20, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 20, 2024

Webrevs

@vieiro
Copy link
Contributor Author

vieiro commented Dec 20, 2024

Build failures are unrelated and are due to

2024-12-20T08:22:54.9429920Z [build.sh][INFO] Downloading https://archive.apache.org/dist/ant/binaries/apache-ant-1.10.8-bin.zip to /home/runner/work/jdk11u-dev/jdk11u-dev/jtreg/src/make/../build/deps/apache-ant-1.10.8-bin.zip
2024-12-20T08:25:09.1723144Z [build.sh][ERROR] wget exited with exit code 4
2024-12-20T08:25:09.1744208Z ##[error]Process completed with exit code 1.

@vieiro
Copy link
Contributor Author

vieiro commented Dec 20, 2024

/approval request Let's keep parity with Oracle 11.0.27 for this one.

@openjdk
Copy link

openjdk bot commented Dec 20, 2024

@vieiro
8331959: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant