-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: gratia: An R package for exploring generalized additive models #6962
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
|
License info: 🟡 License found: |
@dill, @vankesteren, @gavinsimpson this is the review thread for the paper. All of our communications will happen here (and on issues/prs on the submitted repository) from now on. @dill, @vankesteren, as reviewers, the first step for each of you is to create a checklist for your review by entering @editorialbot generate my checklist as the top of a new comment in this thread. These checklists contain the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. The first comment in this thread also contains links to the JOSS reviewer guidelines. The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention #6962 so that a link is created to this thread (and I can keep an eye on what is happening !). Please also feel free to comment and ask questions on this thread. In my experience, it is better to post comments/questions/suggestions as you come across them instead of waiting until you've reviewed the entire package. We aim for reviews to be completed within about 2-4 weeks. Please let me know if any of you require some more time. We can also use EditorialBot (our bot) to set automatic reminders if you know you'll be away for a known period of time. Please feel free to ping me (@lrnv) if you have any questions/concerns. |
@editorialbot add @njtierney as reviewer |
@njtierney added to the reviewers list! |
@njtierney there you go ! Look at the instructions that i wrote for other reviewers in this thread (which is now the review thread, the other one should stay closed up), nice to have you onboard too ! |
Review checklist for @dillConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @njtierneyConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
In terms of conflict of interest: I've worked with @gavinsimpson several times, having written a paper together and taught two courses. I've also made a contribution to |
@dill, Yes, I think we discussed this already in the pre-review, and decided it was fine. |
Comments on the paper are given in gavinsimpson/gratia#296. |
Great! Just wanted to make sure everything was above board here :)On 15 Jul 2024, at 08:23, Oskar Laverny ***@***.***> wrote:
@dill, Yes, I think we discussed this already in the pre-review, and decided it was fine.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Review checklist for @vankesterenConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
I have finished my review and added my comment in the two issues mentioned above. I will update my checklist as the comments are resolved. |
Sorry for the late reply here, I concluded my review with comments listed above in the |
I'm sorry human, I don't understand that. You can see what commands I support by typing:
|
@editorialbot recommend-accept |
|
|
👋 @openjournals/dsais-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#6275, then you can now move forward with accepting the submission by compiling again with the command |
@lrnv Just noticed a minor typo in my affiliation. Is there time to fix this? |
@gavinsimpson Yep you can continue to fix anything you njeed to before the final publication |
@editorialbot generate pdf |
@lrnv I have fixed the two typos I found after a final read through of the proofs and am now finished editing. Thank you for handling my submission to JOSS |
@editorialbot generate pdf 🔍 checking out the following:
|
@editorialbot remove @njtierney from reviewers |
@njtierney is not in the reviewers list |
👋 @gavinsimpson - I just need you to address the following before I move to accept this for publication:
After you have made these changes, let me know. Thanks! |
Thanks |
@editorialbot generate pdf |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🦋🦋🦋 👉 Bluesky post for this paper 👈 🦋🦋🦋 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
🥳 Congratulations on your new publication @gavinsimpson! Many thanks to @lrnv for editing and @dill and @vankesteren for your time, hard work, and expertise!! JOSS wouldn't be able to function nor succeed without your efforts. Please consider becoming a reviewer for JOSS if you are not already: https://reviewers.joss.theoj.org/join |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @gavinsimpson (Gavin L. Simpson)
Repository: https://github.com/gavinsimpson/gratia
Branch with paper.md (empty if default branch): joss-paper
Version: v0.10.0
Editor: @lrnv
Reviewers: @dill, @vankesteren
Archive: 10.5281/zenodo.14531826
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@dill & @vankesteren, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @lrnv know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @dill
📝 Checklist for @njtierney
📝 Checklist for @vankesteren
The text was updated successfully, but these errors were encountered: