chore(readme): Openjs foundation logo + website link on top of document #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this idea. I wonder if we should use some sort of banner instead. |
|
The idea of adding a banner is not bad but it should not take too much space. |
ljharb
reviewed
Mar 21, 2023
ljharb
changed the title
ljharb
reviewed
Mar 28, 2023
ljharb
approved these changes
Mar 28, 2023
Co-authored-by: Jordan Harband <ljharb@gmail.com> Signed-off-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com> Signed-off-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com> Signed-off-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com> Signed-off-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com>
tobie
approved these changes
Mar 29, 2023
joesepi
approved these changes
Mar 31, 2023
tobie
pushed a commit
that referenced
this pull request
Sep 1, 2023
…nt (#1034) * chore(readme): Openjs-foundation logo * chore(readme): Openjs-fondation logo * fix(readme): close tag Co-authored-by: Jordan Harband <ljharb@gmail.com> Signed-off-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com> * Chore(readme): use markdown instead of html Co-authored-by: Jordan Harband <ljharb@gmail.com> Signed-off-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com> * Update README.md Co-authored-by: Jordan Harband <ljharb@gmail.com> Signed-off-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com> * Update README.md Co-authored-by: Jordan Harband <ljharb@gmail.com> Signed-off-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com> * fix(md) --------- Signed-off-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com> Co-authored-by: Jordan Harband <ljharb@gmail.com> Co-authored-by: Joe Sepi <sepi@joesepi.com>
bensternthal
pushed a commit
to bensternthal/cross-project-council
that referenced
this pull request
Apr 23, 2024
…nt (openjs-foundation#1034) * chore(readme): Openjs-foundation logo * chore(readme): Openjs-fondation logo * fix(readme): close tag Co-authored-by: Jordan Harband <ljharb@gmail.com> Signed-off-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com> * Chore(readme): use markdown instead of html Co-authored-by: Jordan Harband <ljharb@gmail.com> Signed-off-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com> * Update README.md Co-authored-by: Jordan Harband <ljharb@gmail.com> Signed-off-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com> * Update README.md Co-authored-by: Jordan Harband <ljharb@gmail.com> Signed-off-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com> * fix(md) --------- Signed-off-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com> Co-authored-by: Jordan Harband <ljharb@gmail.com> Co-authored-by: Joe Sepi <sepi@joesepi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The general idea of this proposal is to add the website link above the readme document.
The logo is there just to look good (it could be reduced in size)