Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ecosystem Sustainability Program (ESP) Page #1309

Merged
merged 4 commits into from
May 30, 2024
Merged

Conversation

bensternthal
Copy link
Contributor

This PR adds information about the OpenJS Ecosystem Sustainability Program, including guidelines and best practices for participating with our first partner, HeroDevs. For additional background, please see #1277

@ljharb @joesepi @tobie

I'd like to fast-track this PR.

@bensternthal bensternthal added the fast-track Pull-Requests that don't have time restrictions label May 29, 2024
@bensternthal bensternthal requested a review from a team as a code owner May 29, 2024 17:29
@ljharb
Copy link
Member

ljharb commented May 29, 2024

(separate comment for fast track thumbs-upping)

Copy link
Contributor

@tobie tobie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m a little uneasy about the idea of partner-specific guidelines. What’s the rationale, here?

README.md Outdated Show resolved Hide resolved
project-resources/ESP/ECOSYSTEM_SUSTAINABILITY_PROGRAM.md Outdated Show resolved Hide resolved
project-resources/ESP/ECOSYSTEM_SUSTAINABILITY_PROGRAM.md Outdated Show resolved Hide resolved
project-resources/ESP/ECOSYSTEM_SUSTAINABILITY_PROGRAM.md Outdated Show resolved Hide resolved
project-resources/ESP/ECOSYSTEM_SUSTAINABILITY_PROGRAM.md Outdated Show resolved Hide resolved
project-resources/ESP/ECOSYSTEM_SUSTAINABILITY_PROGRAM.md Outdated Show resolved Hide resolved
Copy link
Contributor

@tobie tobie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m a little uneasy about the idea of partner-specific guidelines. What’s the rationale, here?

Discussed this offline with @bensternthal. There was agreement to make the guidelines more generic with just the referral links / brand being partner specific. LGTM once this and other comments addressed.

Understand the urgency to merge this. However, please ping CPC members before fast-tracking (eg through the private list or by tagging them here) as this is a bit out of what’s reasonable to fast track imho.

@bensternthal
Copy link
Contributor Author

I'll post an update with the HeroDevs recommendations edited to be general recommendations. @tobie is right that these recommendations are not vendor specific.

If there is a requirement to ping CPC members before fast-tracking it should be added to the docs. Right now it states that if folks disagree they should down vote or remove the label.

@tobie
Copy link
Contributor

tobie commented May 29, 2024

If there is a requirement to ping CPC members before fast-tracking it should be added to the docs. Right now it states that if folks disagree they should down vote or remove the label.

There is indeed no such requirements. Imho, this PR largely exceeds what we customarily accept for fast track. I know there’s a presentation later this week for which this is needed so it felt acceptable to compromise but would require making sure people get a chance to see before it gets merged by doing outreach. Removing the fast-track label for now. Happy to allow it back in if folks think the proposed compromise is acceptable.

@tobie tobie removed the fast-track Pull-Requests that don't have time restrictions label May 29, 2024
@bensternthal
Copy link
Contributor Author

@tobie happy to wait on merging to give folks more time to review.

@ovflowd
Copy link
Member

ovflowd commented May 30, 2024

If there is a requirement to ping CPC members before fast-tracking it should be added to the docs. Right now it states that if folks disagree they should down vote or remove the label.

There is indeed no such requirements. Imho, this PR largely exceeds what we customarily accept for fast track. I know there’s a presentation later this week for which this is needed so it felt acceptable to compromise but would require making sure people get a chance to see before it gets merged by doing outreach. Removing the fast-track label for now. Happy to allow it back in if folks think the proposed compromise is acceptable.

Afaik there is a fast-tracking rule. @bensternthal this is fast-tracked, you can merge it. https://github.com/openjs-foundation/cross-project-council/blob/main/governance/GOVERNANCE.md?plain=1#L197

@ovflowd ovflowd added the fast-track Pull-Requests that don't have time restrictions label May 30, 2024
@tobie
Copy link
Contributor

tobie commented May 30, 2024

For the record, @ovflowd, I had removed the fast-track label (as per the line following the one you linked). I’m open to re-adding it if (1) this needs to be fast-tracked to meet the Friday deadline and (2) there’s additional outreach that’s done to make sure CPC members see it before it’s merged.

@tobie tobie changed the title Add ESP Page Add Ecosystem Sustainability Program (ESP) Page May 30, 2024
Signed-off-by: Tobie Langel <tobie@unlockopen.com>
@tobie tobie requested a review from a team May 30, 2024 15:24
@bensternthal bensternthal merged commit ccef36a into main May 30, 2024
1 check passed
@bensternthal bensternthal deleted the add-esp-page branch May 30, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track Pull-Requests that don't have time restrictions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants