Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update readme for CPC #182

Merged
merged 2 commits into from
Jun 19, 2019

Conversation

MylesBorins
Copy link
Contributor

Currently still specific to Bootstrap.

Old README is archived in artifacts

Refs: https://github.com/nodejs/TSC/blob/master/README.md

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@kborchers
Copy link
Contributor

@MylesBorins would you be willing to also add the list of voting members to at least partially address #181?

@MylesBorins
Copy link
Contributor Author

@kborchers I don't have the list in front of me right now and am a bit heads down for the rest of the day. Feel free to edit / push to this branch. You should have the permissions to do so

@kborchers
Copy link
Contributor

@MylesBorins I pushed a change. Feel free to edit

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

mhdawson commented Jun 5, 2019

@openjs-foundation/cpc would like to get this reviewed/landed so that regular members can start PRing themselves in.

Copy link

@boneskull boneskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm save for my comment

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@MylesBorins
Copy link
Contributor Author

I think all comments have been addressed. The sections for regular members / observers is still there but commented out until we have people to add there.

Will land on wednesday if there are no objections

Copy link
Member

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few typos, but also this lists a total of 16 people in the CPC? And why keep the bootstrap README in the current branch when it's (also) safely in history?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
artifacts/BOOTSTRAP_README.md Show resolved Hide resolved
Currently still specific to Bootstrap.

Old README is archived in artifacts

Refs: https://github.com/nodejs/TSC/blob/master/README.md
@kborchers
Copy link
Contributor

LGTM

README.md Outdated Show resolved Hide resolved
Copy link
Member

@joesepi joesepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins MylesBorins merged commit 8be9a9f into openjs-foundation:master Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.