Fixed icon to toggle dark mode from light mode #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ArshilHapani is attempting to deploy a commit to the OpenJS Foundation Team on Vercel. A member of the Team first needs to authorize it. |
I didn't quite get this sir |
|
Ha ha no worries, if in doubt, just google it |
|
Just a common comment when rubber stamping a small clean PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Sun icon is not visible in light mode when the user has dark mode on their device but light mode on site.
Changes made at
navigation.tsxLine - 27
col - 221
When the user has dark mode on their device and switches to light mode on site then they cannot see the sun icon as it is stroked with a white colour
Footage of before
https://github.com/openjs-foundation/open-visualization/assets/108511809/417bef89-aaa3-4d4a-869a-bc134a39132d
After updated
https://github.com/openjs-foundation/open-visualization/assets/108511809/ca5d363f-7cfe-446a-8878-d56d90dc423f