Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summit Topic: Promises #119

Closed
BridgeAR opened this issue Oct 9, 2018 · 11 comments
Closed

Summit Topic: Promises #119

BridgeAR opened this issue Oct 9, 2018 · 11 comments

Comments

@BridgeAR
Copy link

BridgeAR commented Oct 9, 2018

Abstract

Last summit the promise debugging group was very valuable and it's time to recap and continue the ongoing efforts.
To do so here's a rough agenda for the meeting. Please feel encouraged to suggest further topics.

Proposed agenda

@nodejs/promises-debugging for visibility.

@misterdjules
Copy link

@BridgeAR That looks great!

I was wondering whether:

New promise APIs in core (DNS, streams async iterators, ...)

would be better for the more general "Promises" session, as it seems it's not specific to debugging.

@BridgeAR BridgeAR changed the title Summit Topic: Promise debugging Summit Topic: Promises Oct 9, 2018
@BridgeAR
Copy link
Author

BridgeAR commented Oct 9, 2018

@misterdjules I fixed the title as this should actually just be the agenda for the general promises part.

@BridgeAR
Copy link
Author

One more point that we should talk about:

util.promisify likely becomes an anti-pattern soon due to loosing the stack trace compared to async / await.

Some raw takes for me on this:

  • we should make sure that Node internal code always uses async / await and not regular promises.
  • we should discourage usage of that function and recommend to use async / await everywhere throughout the ecosystem, if possible.

@bmeurer
Copy link

bmeurer commented Oct 13, 2018

You'll loose the stack trace with any callback based API. I was already thinking that we could introduce some kind of zone mechanism in Node to provide V8 with context information necessary to rebuild the stack trace.

@benjamingr
Copy link

util.promisify likely becomes an anti-pattern soon due to loosing the stack trace compared to async / await.

Can you explain this to me? Isn't the stack trace lost only after the promisifed functions?

I think this is more of a promises-guide concern (tell people to always promisify at the lowest level)

@benjamingr
Copy link

Would also love it if the sinon issue was discussed (testing fake timers with async functions)

@devsnek
Copy link

devsnek commented Oct 13, 2018

will remote participation be available?

@mcollina
Copy link
Member

mcollina commented Oct 13, 2018 via email

@BridgeAR
Copy link
Author

BridgeAR commented Oct 13, 2018

To join the meeting please use zoom: https://zoom.us/j/327915725
Update: Having problem with the microphone. I am trying to fix it quickly but I can not give any guarantees.

@BridgeAR
Copy link
Author

Here we go https://zoom.us/j/756090104

@mmarchini
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants