-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kruise rollout v0.5.0 #81
Conversation
- update | ||
- apiGroups: | ||
- "" | ||
resources: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we need global configmap list and get ?
- update | ||
- apiGroups: | ||
- "" | ||
resources: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we need global secrets list and get ?
type: string | ||
trafficRoutings: | ||
description: TrafficRoutings hosts all the supported service | ||
meshes supported to enable more fine-grained traffic routing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
traffic routines is not necessary service mesh, consider rephase the descriptions
x-kubernetes-list-type: map | ||
type: object | ||
traffic: | ||
description: Traffic indicate how many percentage of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plz describe the value format in the description
Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
576f88b
to
b9c5911
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furykerry The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Changes are automatically published when merged to
master
. They are not published on branches.