Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*): add volcengine cloud provider and clb plugin #127

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

lizhipeng629
Copy link
Contributor

@lizhipeng629 lizhipeng629 commented Jan 26, 2024

Add the volcengine provider to open-kruise-game and add the clb plugin.

  • Users can declare the required clb id and the corresponding backend pod port in okg's gameserverset resource.

-OKG will automatically help users create corresponding services to implement traffic forwarding
Implementation principle

  • Through okg, when creating a service, add clb-related anno to the service; then the cloud-controller-manager component in the vke cluster will recognize the clb anno in the service, create a listener on the clb side, and bind the back-end server group , realize traffic forwarding

Details can be found in the README

@kruise-bot
Copy link

Welcome @lizhipeng629! It looks like this is your first PR to openkruise/kruise-game 🎉

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 175 lines in your changes are missing coverage. Please review.

Comparison is base (2b6ce6f) 39.12% compared to head (cc46913) 39.96%.

Files Patch % Lines
cloudprovider/volcengine/clb.go 50.00% 158 Missing and 5 partials ⚠️
cloudprovider/volcengine/volcengine.go 20.00% 11 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
+ Coverage   39.12%   39.96%   +0.84%     
==========================================
  Files          26       28       +2     
  Lines        3581     3923     +342     
==========================================
+ Hits         1401     1568     +167     
- Misses       2098     2267     +169     
- Partials       82       88       +6     
Flag Coverage Δ
unittests 39.96% <48.83%> (+0.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lizhipeng629 lizhipeng629 force-pushed the feat-volcengine-provider branch 2 times, most recently from 053fb9a to 0ceb0df Compare January 29, 2024 06:25
Copy link

@flyer103 flyer103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: flyer103
Once this PR has been reviewed and has the lgtm label, please assign fillzpp for approval by writing /assign @fillzpp in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ringtail
Copy link
Member

/LGTM

@ringtail ringtail merged commit 9c203d0 into openkruise:master Jan 29, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants