Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deployment rollback when in the process of cannary/partition #91

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

myname4423
Copy link
Contributor

a solution for issue #84 (also #80)

Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: yunbo <yunbo10124scut@gmail.com>

add comment

Signed-off-by: yunbo <yunbo10124scut@gmail.com>

an improvement for canary rollback during another rollback

Signed-off-by: yunbo <yunbo10124scut@gmail.com>
@kruise-bot
Copy link

New changes are detected. LGTM label has been removed.

Copy link
Member

@hantmac hantmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! /LGTM

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hantmac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hantmac hantmac merged commit 519472c into openkruise:master Feb 4, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants