Feat: check whether the updatedReadyPodsCount greater than minUpdated…

…ReadyPodsCount Signed-off-by: Hanmengnan <1448189829@qq.com>
openkruise · Jul 23, 2023 · 1656674 · 1656674
1 parent 4e35a1d
commit 1656674
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/pkg/controller/daemonset/daemonset_controller.go b/pkg/controller/daemonset/daemonset_controller.go
@@ -415,11 +415,11 @@ func (dsc *ReconcileDaemonSet) syncDaemonSet(request reconcile.Request) error {
 					klog.Errorf("Failed to GetScaledValueFromIntOrPercent of minUpdatedReadyPods for %s: %v", request, err)
 				}
 			}
-			// todo: check whether the updatedReadyPodsCount greater than minUpdatedReadyPodsCount
-			_ = minUpdatedReadyPodsCount
-			// pre-download images for new revision
-			if err := dsc.createImagePullJobsForInPlaceUpdate(ds, old, cur); err != nil {
-				klog.Errorf("Failed to create ImagePullJobs for %s: %v", request, err)
+			if minUpdatedReadyPodsCount <= int(ds.Status.UpdatedNumberScheduled) {
+				// pre-download images for new revision
+				if err := dsc.createImagePullJobsForInPlaceUpdate(ds, old, cur); err != nil {
+					klog.Errorf("Failed to create ImagePullJobs for %s: %v", request, err)
+				}
 			}
 		} else {
 			// delete ImagePullJobs if revisions have been consistent