SidecarSet add upgrade state in pod annotation

Signed-off-by: pingjiang <xiangpingjiang1998@gmail.com>
openkruise · Aug 20, 2023 · 2961add · 2961add
1 parent 4e35a1d
commit 2961add
Show file tree

Hide file tree

Showing 3 changed files with 102 additions and 0 deletions.
diff --git a/pkg/control/sidecarcontrol/util.go b/pkg/control/sidecarcontrol/util.go
@@ -81,6 +81,7 @@ type SidecarSetUpgradeSpec struct {
 	SidecarSetName               string      `json:"sidecarSetName"`
 	SidecarList                  []string    `json:"sidecarList"`                  // sidecarSet container list
 	SidecarSetControllerRevision string      `json:"controllerRevision,omitempty"` // sidecarSet controllerRevision name
+	State                        string      `json:"state"`                        // enum: Normal, Updating
 }
 
 // PodMatchSidecarSet determines if pod match Selector of sidecar.
@@ -253,6 +254,90 @@ func UpdatePodSidecarSetHash(pod *corev1.Pod, sidecarSet *appsv1alpha1.SidecarSe
 		SidecarSetName:               sidecarSet.Name,
 		SidecarList:                  sidecarList.List(),
 		SidecarSetControllerRevision: sidecarSet.Status.LatestRevision,
+		State:                        "Updating",
+	}
+	newHash, _ := json.Marshal(sidecarSetHash)
+	pod.Annotations[hashKey] = string(newHash)
+}
+
+func IsSiderCarContainersReady(pod *corev1.Pod, containers sets.String) bool {
+	for _, cs := range pod.Status.ContainerStatuses {
+		// only check containers set
+		if !containers.Has(cs.Name) {
+			continue
+		}
+		if !cs.Ready {
+			return false
+		}
+	}
+	return true
+}
+
+func IsPodFinishSiderCarContainersUpdate(pod *corev1.Pod, sidecarSet *appsv1alpha1.SidecarSet) bool {
+	sidecars := GetSidecarContainersInPod(sidecarSet)
+	if _, ok := pod.Annotations[SidecarsetInplaceUpdateStateKey]; ok {
+		if IsSidecarContainerUpdateCompleted(pod, sets.NewString(sidecarSet.Name), sidecars) && IsSiderCarContainersReady(pod, sidecars) {
+			return true
+		}
+	} else {
+		if IsSiderCarContainersReady(pod, sidecars) {
+			return true
+		}
+	}
+	return false
+}
+
+func GetPodSidecarSetHashState(pod *corev1.Pod, sidecarSet *appsv1alpha1.SidecarSet) string {
+	hashKey := SidecarSetHashAnnotation
+	sidecarSetHash := make(map[string]SidecarSetUpgradeSpec)
+	if err := json.Unmarshal([]byte(pod.Annotations[hashKey]), &sidecarSetHash); err != nil {
+		klog.Errorf("unmarshal pod(%s/%s) annotations[%s] failed: %s", pod.Namespace, pod.Name, hashKey, err.Error())
+
+		// to be compatible with older sidecarSet hash struct, map[string]string
+		olderSidecarSetHash := make(map[string]string)
+		if err = json.Unmarshal([]byte(pod.Annotations[hashKey]), &olderSidecarSetHash); err == nil {
+			for k, v := range olderSidecarSetHash {
+				sidecarSetHash[k] = SidecarSetUpgradeSpec{
+					SidecarSetHash:  v,
+					UpdateTimestamp: metav1.Now(),
+					SidecarSetName:  sidecarSet.Name,
+				}
+			}
+		}
+	}
+	return sidecarSetHash[sidecarSet.Name].State
+}
+
+func UpdatePodSidecarSetHashState(pod *corev1.Pod, sidecarSet *appsv1alpha1.SidecarSet) {
+	hashKey := SidecarSetHashAnnotation
+	sidecarSetHash := make(map[string]SidecarSetUpgradeSpec)
+	if err := json.Unmarshal([]byte(pod.Annotations[hashKey]), &sidecarSetHash); err != nil {
+		klog.Errorf("unmarshal pod(%s/%s) annotations[%s] failed: %s", pod.Namespace, pod.Name, hashKey, err.Error())
+
+		// to be compatible with older sidecarSet hash struct, map[string]string
+		olderSidecarSetHash := make(map[string]string)
+		if err = json.Unmarshal([]byte(pod.Annotations[hashKey]), &olderSidecarSetHash); err == nil {
+			for k, v := range olderSidecarSetHash {
+				sidecarSetHash[k] = SidecarSetUpgradeSpec{
+					SidecarSetHash:  v,
+					UpdateTimestamp: metav1.Now(),
+					SidecarSetName:  sidecarSet.Name,
+				}
+			}
+		}
+	}
+	sidecarList := sets.NewString()
+	for _, sidecar := range sidecarSet.Spec.Containers {
+		sidecarList.Insert(sidecar.Name)
+	}
+
+	sidecarSetHash[sidecarSet.Name] = SidecarSetUpgradeSpec{
+		UpdateTimestamp:              metav1.Now(),
+		SidecarSetHash:               GetSidecarSetRevision(sidecarSet),
+		SidecarSetName:               sidecarSet.Name,
+		SidecarList:                  sidecarList.List(),
+		SidecarSetControllerRevision: sidecarSet.Status.LatestRevision,
+		State:                        "Normal",
 	}
 	newHash, _ := json.Marshal(sidecarSetHash)
 	pod.Annotations[hashKey] = string(newHash)

diff --git a/pkg/controller/sidecarset/sidecarset_processor.go b/pkg/controller/sidecarset/sidecarset_processor.go
@@ -77,6 +77,15 @@ func (p *Processor) UpdateSidecarSet(sidecarSet *appsv1alpha1.SidecarSet) (recon
 		return reconcile.Result{}, err
 	}
 
+	// check if pod finish sidecar container upgrade
+	for _, pod := range pods {
+		if sidecarcontrol.IsPodFinishSiderCarContainersUpdate(pod, sidecarSet) && sidecarcontrol.GetPodSidecarSetHashState(pod, sidecarSet) != "Normal" {
+			klog.V(3).Infof("#################################")
+			sidecarcontrol.UpdatePodSidecarSetHashState(pod, sidecarSet)
+			p.Client.Update(context.TODO(), pod)
+		}
+	}
+
 	// register new revision if this sidecarSet is the latest;
 	// return the latest revision that corresponds to this sidecarSet.
 	latestRevision, collisionCount, err := p.registerLatestRevision(sidecarSet, pods)

diff --git a/pkg/webhook/pod/mutating/sidecarset.go b/pkg/webhook/pod/mutating/sidecarset.go
@@ -450,6 +450,14 @@ func buildSidecars(isUpdated bool, pod *corev1.Pod, oldPod *corev1.Pod, matchedS
 			sidecarSetHash[sidecarSet.Name] = setUpgrade1
 			sidecarSetHashWithoutImage[sidecarSet.Name] = setUpgrade2
 		}
+		sidecarSetHash[sidecarSet.Name] = sidecarcontrol.SidecarSetUpgradeSpec{
+			UpdateTimestamp:              metav1.Now(),
+			SidecarSetHash:               sidecarSetHash[sidecarSet.Name].SidecarSetHash,
+			SidecarSetName:               sidecarSet.Name,
+			SidecarList:                  sidecarList.List(),
+			SidecarSetControllerRevision: sidecarSetHash[sidecarSet.Name].SidecarSetControllerRevision,
+			State:                        "Updating",
+		}
 	}
 
 	// store sidecarset hash in pod annotations