Skip to content

Commit

Permalink
add start ordinal e2e case
Browse files Browse the repository at this point in the history
Signed-off-by: Abner-1 <yuanyuxing.yyx@alibaba-inc.com>
  • Loading branch information
ABNER-1 committed Jun 13, 2024
1 parent 68159dd commit 37a905b
Show file tree
Hide file tree
Showing 6 changed files with 636 additions and 8 deletions.
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ require (
github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
github.com/golang/protobuf v1.5.4 // indirect
github.com/gomodule/redigo v2.0.0+incompatible // indirect
github.com/google/go-cmp v0.6.0 // indirect
github.com/google/go-cmp v0.6.0
github.com/google/gofuzz v1.2.0 // indirect
github.com/google/uuid v1.6.0 // indirect
github.com/grpc-ecosystem/grpc-gateway/v2 v2.19.0 // indirect
Expand Down
4 changes: 2 additions & 2 deletions pkg/controller/statefulset/stateful_set_control.go
Original file line number Diff line number Diff line change
Expand Up @@ -997,6 +997,8 @@ func (ssc *defaultStatefulSetControl) processCondemned(ctx context.Context, set
// If decreaseAndCheckMaxUnavailable(scaleMaxUnavailable) returns true,
// break the pod for-loop and proceed with the update logic,
// which will apply in-place conditions to make the pod ready.
//
// For example: update unhealthy pods or add some conditions
func (ssc *defaultStatefulSetControl) processReplica(
ctx context.Context,
set *appsv1beta1.StatefulSet,
Expand Down Expand Up @@ -1051,8 +1053,6 @@ func (ssc *defaultStatefulSetControl) processReplica(
set.Namespace,
set.Name,
replicas[i].Name)
// here, we change break action in for-loop to exit update function
// todo: pay attention to this change
return false, true, nil
}
// pod created, no more work possible for this round
Expand Down
Loading

0 comments on commit 37a905b

Please sign in to comment.