Skip to content

Commit

Permalink
[enhancement] fix comment error for function isJobFailed of broadcast…
Browse files Browse the repository at this point in the history
…job (#1348)

Signed-off-by: Colvin-Y <ykwhrimfaxi@gmail.com>
  • Loading branch information
Colvin-Y committed Aug 4, 2023
1 parent a44ca54 commit 915b0ab
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/controller/broadcastjob/broadcastjob_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,7 @@ func isJobComplete(job *appsv1alpha1.BroadcastJob, desiredNodes map[string]*core
return true
}

// isJobFailed checks if the job CompletionPolicy is not Never, and it has past the backofflimit or ActiveDeadlineSeconds.
// isJobFailed checks if the job CompletionPolicy is not Never, and it has past ActiveDeadlineSeconds.
func isJobFailed(job *appsv1alpha1.BroadcastJob, pods []*corev1.Pod) (bool, string, string) {
if job.Spec.CompletionPolicy.Type == appsv1alpha1.Never {
return false, "", ""
Expand Down

0 comments on commit 915b0ab

Please sign in to comment.