optimize container launch priority event handler (#1283)

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
openkruise · May 12, 2023 · b39e08c · b39e08c
1 parent ccd94b2
commit b39e08c
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/pkg/controller/containerlaunchpriority/container_launch_priority_controller.go b/pkg/controller/containerlaunchpriority/container_launch_priority_controller.go
@@ -69,12 +69,14 @@ func add(mgr manager.Manager, r *ReconcileContainerLaunchPriority) error {
 		CreateFunc: func(e event.CreateEvent) bool {
 			pod := e.Object.(*v1.Pod)
 			_, containersReady := podutil.GetPodCondition(&pod.Status, v1.ContainersReady)
-			return utilcontainerlaunchpriority.ExistsPriorities(pod) && containersReady != nil && containersReady.Status != v1.ConditionTrue
+			// If in vk scenario, there will be not containerReady condition
+			return utilcontainerlaunchpriority.ExistsPriorities(pod) && (containersReady == nil || containersReady.Status != v1.ConditionTrue)
 		},
 		UpdateFunc: func(e event.UpdateEvent) bool {
 			pod := e.ObjectNew.(*v1.Pod)
 			_, containersReady := podutil.GetPodCondition(&pod.Status, v1.ContainersReady)
-			return utilcontainerlaunchpriority.ExistsPriorities(pod) && containersReady != nil && containersReady.Status != v1.ConditionTrue
+			// If in vk scenario, there will be not containerReady condition
+			return utilcontainerlaunchpriority.ExistsPriorities(pod) && (containersReady == nil || containersReady.Status != v1.ConditionTrue)
 		},
 		DeleteFunc: func(e event.DeleteEvent) bool {
 			return false