Skip to content

Commit

Permalink
fix typo and polish
Browse files Browse the repository at this point in the history
Signed-off-by: Megrez Lu <lujiajing1126@gmail.com>
  • Loading branch information
lujiajing1126 committed Mar 15, 2024
1 parent 4a4432a commit ba67c7d
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions docs/proposals/20240315-pathandqueryparams.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ So far, OpenKruise Rollouts simply supports `Header` as the matchers for traffic

### Goals

- Support Path and/or QueryParams for Gateway API, Istio Mesh and Ingress (Specfically, MSE and Gateway API)
- Support Path and/or QueryParams for Gateway API, Istio Mesh and Ingress (Specifically, MSE and Gateway API)

### Non-Goals/Future Work

Expand Down Expand Up @@ -81,7 +81,7 @@ type HttpRouteMatch struct {

// Existing

// Headers specifies HTTP request header matchers. Multiple match values are
// Headers specifies HTTP request header matchers. Multiple match values are
// ANDed together, meaning, a request must match all the specified headers
// to select the route.
//
Expand All @@ -106,7 +106,6 @@ Currently, only one trafficRouting provider is supported. Then we may consider t
- MSE Ingress: User can define queryParams, but it **SHOULD NOT** be used together with Headers due to priority and backward-compatibility.
- Istio: User can define path and/or queryParams and use without any issue.
- Gateway API: User can define path and/or queryParams. But one of them can take effect if and only if Headers are not defined.
-

### Implementation Details/Notes/Constraints

Expand Down

0 comments on commit ba67c7d

Please sign in to comment.