enhancement: ambiguous function name of isSidecarSetNotUpdate (#1343)

Signed-off-by: Colvin-Y <ykwhrimfaxi@gmail.com>
openkruise · Jul 27, 2023 · d948587 · d948587
1 parent 4e35a1d
commit d948587
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/pkg/controller/sidecarset/sidecarset_processor.go b/pkg/controller/sidecarset/sidecarset_processor.go
@@ -131,7 +131,7 @@ func (p *Processor) UpdateSidecarSet(sidecarSet *appsv1alpha1.SidecarSet) (recon
 	}
 
 	// 4. SidecarSet upgrade strategy type is NotUpdate
-	if !isSidecarSetNotUpdate(sidecarSet) {
+	if isSidecarSetNotUpdate(sidecarSet) {
 		return reconcile.Result{}, nil
 	}
 
@@ -535,9 +535,9 @@ func calculateStatus(control sidecarcontrol.SidecarControl, pods []*corev1.Pod,
 func isSidecarSetNotUpdate(s *appsv1alpha1.SidecarSet) bool {
 	if s.Spec.UpdateStrategy.Type == appsv1alpha1.NotUpdateSidecarSetStrategyType {
 		klog.V(3).Infof("sidecarSet spreading RollingUpdate config type, name: %s, type: %s", s.Name, s.Spec.UpdateStrategy.Type)
-		return false
+		return true
 	}
-	return true
+	return false
 }
 
 func updateContainerInPod(container corev1.Container, pod *corev1.Pod) {