Skip to content

Commit

Permalink
fix typo and remove incident-response (#1584)
Browse files Browse the repository at this point in the history
Signed-off-by: 守辰 <shouchen.zz@alibaba-inc.com>
  • Loading branch information
furykerry committed Apr 17, 2024
1 parent 2753c3a commit f244b7a
Show file tree
Hide file tree
Showing 10 changed files with 19 additions and 101 deletions.
2 changes: 1 addition & 1 deletion docs/proposals/20210713-sidecarsetimagepullsecrects.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ One of the most common-used features of it is to pull images from private reposi

## Proposal
**Main idea**: In this design, we separate the logic of `Secret` and `SidecarSet`.
In `SidecarSet` part, we only consider injecting their `imagePullSecrets` feilds into Pod.
In `SidecarSet` part, we only consider injecting their `imagePullSecrets` fields into Pod.
Users should manually distribute the required `Secrets` to all the namespaces that the `SidecarSet` may be instantiated.

### API Definition
Expand Down
6 changes: 3 additions & 3 deletions docs/proposals/20210826-ephemeraljob.md
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ the number of creating ephemeralcontainer will not exceed replicas.

the value of parallelism cannot exceed 10.

1. templete describe ephemeralcontainers spec.
1. template describe ephemeralcontainers spec.

1. ttlSecondsAfterCreated means the TTL duration after ephemeral job has created.

Expand Down Expand Up @@ -133,7 +133,7 @@ status:

The status.phase can be:

- Waitting: this EJOB waits ephemeral containers to be created.
- Waiting: this EJOB waits ephemeral containers to be created.

it means no ephemeral container reach to running state.

Expand All @@ -152,7 +152,7 @@ already failed to complete it's task.
- Error: some errors exits during ephemeralcontaienr creating.

status.failed means the number of failed completed ephemeralcontainers.
status.success means the number of success compeleted ephemeralcontainers.
status.success means the number of success completed ephemeralcontainers.
status.waiting means the number of waiting ephemeralcontainers.
status.running means the number of running ephemeralcontainers.

Expand Down
89 changes: 0 additions & 89 deletions incident-response.md

This file was deleted.

2 changes: 1 addition & 1 deletion pkg/controller/statefulset/stateful_pod_control_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,7 @@ func TestStatefulPodControlDeleteFailure(t *testing.T) {
}
}

func TestStatefulPodControlClaimsMatchDeletionPolcy(t *testing.T) {
func TestStatefulPodControlClaimsMatchDeletionPolicy(t *testing.T) {
// The claimOwnerMatchesSetAndPod is tested exhaustively in stateful_set_utils_test; this
// test is for the wiring to the method tested there.
fakeClient := &fake.Clientset{}
Expand Down
2 changes: 1 addition & 1 deletion pkg/controller/statefulset/stateful_set_utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,7 @@ func completeRollingUpdate(set *appsv1beta1.StatefulSet, status *appsv1beta1.Sta
}
}

// SortPodsAscendingOrdinal sorts the given Pods according to their oridinals.
// SortPodsAscendingOrdinal sorts the given Pods according to their ordinals.
func SortPodsAscendingOrdinal(pods []*v1.Pod) {
sort.Sort(ascendingOrdinal(pods))
}
Expand Down
6 changes: 3 additions & 3 deletions pkg/controller/workloadspread/reschedule_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -315,13 +315,13 @@ func TestRescheduleSubset(t *testing.T) {
ec := GetWorkloadSpreadSubsetCondition(&exceptStatus.SubsetStatuses[i], appsv1alpha1.SubsetSchedulable)

if lc == nil && ec != nil {
t.Fatalf("rescheudle failed")
t.Fatalf("reschedule failed")
}
if lc != nil && ec == nil {
t.Fatalf("rescheudle failed")
t.Fatalf("reschedule failed")
}
if lc != nil && ec != nil && lc.Status != ec.Status {
t.Fatalf("rescheudle failed")
t.Fatalf("reschedule failed")
}
}
})
Expand Down
2 changes: 1 addition & 1 deletion pkg/util/ownerref_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ func TestHasOwnerRef(t *testing.T) {
}
}

func TestRemoveOnwer(t *testing.T) {
func TestRemoveOwner(t *testing.T) {
pvc := &v1.PersistentVolumeClaim{
ObjectMeta: metav1.ObjectMeta{
Namespace: "default",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ func (h *PodCreateHandler) containerLaunchPriorityInitialization(_ context.Conte
return false, nil
}

// the return []int is prioirty for each container in the pod, ordered as container
// the return []int is priority for each container in the pod, ordered as container
// order list in pod spec.
// the priorityFlag indicates whether this pod needs to launch containers with priority.
// return error is there is any (e.g. priority value less than minimum possible int value)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ func (h *ResourceDistributionCreateUpdateHandler) validateResourceDistributionSp
}
}
if len(conflicted) != 0 {
allErrs = append(allErrs, field.Invalid(fldPath, targets, fmt.Sprintf("ambiguous targets because namespace %v is in both IncludedNamespaces.List and ExcludedNamesapces.List", conflicted)))
allErrs = append(allErrs, field.Invalid(fldPath, targets, fmt.Sprintf("ambiguous targets because namespace %v is in both IncludedNamespaces.List and ExcludedNamespaces.List", conflicted)))
}

// 2. validate targets.NamespaceLabelSelector
Expand Down
7 changes: 7 additions & 0 deletions typos.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,12 @@ Ded = "Ded"
ons = "ons"
ist = "ist"
WITHO = "WITHO"

[default]
extend-ignore-re = [
# *sigh* this just isn't worth the cost of fixing
"sha256:.*",
]

[files]
extend-exclude = ["vendor/", "go.mod", "CHANGELOG.md"]

0 comments on commit f244b7a

Please sign in to comment.