Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature request] In-place udpate support resources #1212

Open
zmberg opened this issue Mar 9, 2023 · 2 comments · May be fixed by #1336 or #1353
Open

[feature request] In-place udpate support resources #1212

zmberg opened this issue Mar 9, 2023 · 2 comments · May be fixed by #1336 or #1353
Assignees
@LavenderQAQ
Labels
kind/enhancement New feature or request kind/feature-request kind/good-idea Good Idea

Comments

@zmberg
Copy link
Member

zmberg commented Mar 9, 2023

What would you like to be added:
The In-place Pod Vertical Scaling feature have been merged in k8s upstream, so openKruise in-place update need support resources, related workloads:

  • CloneSet
  • Advanced StatefulSet
  • Advanced DaemonSet
  • SidecarSet
@zmberg zmberg closed this as completed Jun 8, 2023
@zmberg zmberg reopened this Jul 14, 2023
@LavenderQAQ
Copy link

/assign

This was referenced Jul 14, 2023
Closed
Open
@LavenderQAQ LavenderQAQ linked a pull request Aug 2, 2023 that will close this issue
Open
@zmberg zmberg closed this as completed Apr 9, 2024
@ABNER-1 ABNER-1 reopened this Aug 28, 2024
@github-project-automation github-project-automation bot moved this to In progress in Roadmap Aug 29, 2024
@ABNER-1
Copy link
Member

ABNER-1 commented Sep 14, 2024

I encountered two errors while adding e2e test cases:

  1. When modifying the image and increasing resources simultaneously, I encountered a RunContainerError. I have already submitted an issue to the Kubernetes community at [InPlacePodVerticalScaling]Got RunContainerError when patch pod image and resources kubernetes/kubernetes#127356.

  2. When I scaled the CPU limit of resources from 100m to 200m, I observed that occasionally the status was first changed by kubelet from 100m InProcess to 200m, and then it was set back to 100m InProcess by kubelet, and after a while, it finally became 200m.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LavenderQAQ LavenderQAQ

Labels
kind/enhancement New feature or request kind/feature-request kind/good-idea Good Idea
Projects
Roadmap
Status: In progress
Milestone
No milestone
3 participants
@ABNER-1 @zmberg @LavenderQAQ