-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enhanced in-place update module to support vertical scaling #1353
feat: enhanced in-place update module to support vertical scaling #1353
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sonatype Lift is retiringSonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. |
08c47c7
to
04b5eb8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1353 +/- ##
==========================================
- Coverage 48.55% 47.54% -1.01%
==========================================
Files 157 153 -4
Lines 22480 21805 -675
==========================================
- Hits 10916 10368 -548
+ Misses 10360 10301 -59
+ Partials 1204 1136 -68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0470ce2
to
4e13c0d
Compare
35c4939
to
28406cb
Compare
48126ff
to
aca435f
Compare
The complete logic needs to wait until the k8s api of kruise is upgraded. |
/hold |
aca435f
to
d064af1
Compare
d064af1
to
cbd728f
Compare
2d14fc1
to
e0b65be
Compare
248e6e7
to
db22089
Compare
db22089
to
8fd6bad
Compare
70b03b2
to
ff3e27e
Compare
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
cf9de87
to
50f632e
Compare
Signed-off-by: LavenderQAQ <lavenderqaq.cs@gmail.com>
Signed-off-by: LavenderQAQ <lavenderqaq.cs@gmail.com>
…tations Signed-off-by: LavenderQAQ <lavenderqaq.cs@gmail.com>
Signed-off-by: LavenderQAQ <lavenderqaq.cs@gmail.com>
50f632e
to
8cdf30a
Compare
@LavenderQAQ: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Ⅰ. Describe what this PR does
Enhanced the in-place update module to enable kruise's workload to modify resources without restarting the pod.
Ⅱ. Does this pull request fix one issue?
Fixes #1212
Ⅲ. Describe how to verify it
Need to kubernetes v1.27 version, and open feature gate
InPlacePodVerticalScaling
. Here is my kind configuration:Build a cloneset (or other workload that includes in-place updates) and set updateStrategy to InPlaceIfPossible. Here's an example:
Change the workload's resources, wait a while, and you'll find that the pod's resources will change, and the pod won't restart.
Ⅳ. Special notes for reviews
The control of Status for vertical scaling requires a higher version of the k8s api, which makes this pr need to wait for kruise version upgrade. It cannot be merged at this time because it is not yet complete.