Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature request] Advanced Workload pre-download image support attach metadata in ImagePullJob #1240

Closed
zmberg opened this issue Mar 30, 2023 · 2 comments · Fixed by #1246
Closed

[feature request] Advanced Workload pre-download image support attach metadata in ImagePullJob #1240

zmberg opened this issue Mar 30, 2023 · 2 comments · Fixed by #1246
Assignees
@YTGhost
Labels
kind/feature-request kind/good-first-issue Good for newcomers
Milestone
v1.5

Comments

@zmberg
Copy link
Member

zmberg commented Mar 30, 2023

What would you like to be added:
ImagePullJob support attach metadata into cri interface, issue #1155.

And Kruise Advanced Workload also need to support this feature, related code: https://github.com/openkruise/kruise/blob/master/pkg/util/imagejob/utilfunction/imagejob_util.go#L54
@YTGhost
Copy link
Contributor

YTGhost commented Apr 7, 2023

I am interested in this work, can you assign it to me?

@veophi
Copy link
Member

veophi commented Apr 7, 2023

/assign @YTGhost

@YTGhost YTGhost mentioned this issue Apr 7, 2023
Merged
@zmberg zmberg added this to the v1.5 milestone Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YTGhost YTGhost

Labels
kind/feature-request kind/good-first-issue Good for newcomers
Projects
None yet
Milestone
v1.5
Development

Successfully merging a pull request may close this issue.

feat: Advanced Workload pre-download image support attach metadata in ImagePullJob YTGhost/kruise
3 participants
@zmberg @veophi @YTGhost