-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature request] SidecarSet add upgrade state in pod annotation #1312
Labels
Projects
Milestone
Comments
/assign |
Yes, you are right. You can update the sidecarset annotations[kruise.io/sidecarset-hash] |
Ok, I will do that recentlly |
@zmberg Hello, I want to work on this issue, can you assign it to me? |
/assign |
LvWuqian
added a commit
to LvWuqian/kruise
that referenced
this issue
Jul 17, 2024
LvWuqian
added a commit
to LvWuqian/kruise
that referenced
this issue
Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
What would you like to be added:
SidecarSet can publish Sidecar containers in batches, and currently needs to add a representation to make it easier for upper-level paas to support more clearly which Pods are in the process of being published and which are finished.
Currently Pod have sidecarset annotations[kruise.io/sidecarset-hash] and value is struct:
So we can add field in the above struct:
Related Code: https://github.com/openkruise/kruise/blob/master/pkg/control/sidecarcontrol/util.go#L63
The text was updated successfully, but these errors were encountered: