Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] support structured logging #1551

Closed
2 of 6 tasks
furykerry opened this issue Mar 29, 2024 · 5 comments · Fixed by #1669
Closed
2 of 6 tasks

[feature request] support structured logging #1551

furykerry opened this issue Mar 29, 2024 · 5 comments · Fixed by #1669

Comments

@furykerry
Copy link
Member

furykerry commented Mar 29, 2024

What would you like to be added:
Follow the proposal of kubernetes, OpenKruise should use structured logging instead of unstructured logging and shall output json format if argument --logging-format=json is used.
https://kubernetes.io/blog/2020/09/04/kubernetes-1-19-introducing-structured-logs/

Pick a file or directory that you would like to improve and migrate existing log calls to use structured logs. It's a great and easy way to make your first contribution to Kruise!

Why is this needed:
OpenKruise currently use unstructured plain text as the logging format, which may logging processing hard.

  • pkg/control
  • pkg/controller
  • pkg/daemon
  • pkg/webhook
  • pkg/util
  • cmd
@MajLuu
Copy link
Contributor

MajLuu commented Mar 31, 2024

/assign
I will try to add structured logging in pkg/control dir, if i do it quickly, I will be pleasure to try other instances.

@manan1979
Copy link

is this issue open?

@furykerry
Copy link
Member Author

yes,it is still open, other packages also need structured logging, i've updated the issue to list the packages need structured logging change

@jairuigou
Copy link
Contributor

Hi, I want to try pkg/controller for my first commit to Kruise. Is anyone else working on this package?

@furykerry
Copy link
Member Author

/assign @jairuigou

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants