-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support structured logging #1669
support structured logging #1669
Conversation
Welcome @AiRanthem! It looks like this is your first PR to openkruise/kruise 🎉 |
190126f
to
2560f21
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1669 +/- ##
==========================================
+ Coverage 47.91% 48.80% +0.88%
==========================================
Files 162 188 +26
Lines 23491 19278 -4213
==========================================
- Hits 11256 9408 -1848
+ Misses 11014 8639 -2375
- Partials 1221 1231 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pkg/webhook/daemonset/validating/daemonset_create_update_handler.go
Outdated
Show resolved
Hide resolved
pkg/webhook/imagelistpulljob/validating/imagelistpulljob_create_update_handler.go
Outdated
Show resolved
Hide resolved
611b314
to
b4f32bc
Compare
Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com>
064bc90
to
13c9399
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furykerry The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Structured logging output is supported for the packages below:
Specifically, method calls similar to
klog.Infof
within these packages have been replaced with structured interfaces likeklog.InfoS
.Ⅱ. Does this pull request fix one issue?
fixes #1551
Ⅲ. Describe how to verify it
Read the logs generated by Kruise.
Ⅳ. Special notes for reviews
PLZ do read every changes very carefully to ensure that they convey the same meaning as before.