Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add switch for PersistentPodState controller #1002

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

veophi
Copy link
Member

@veophi veophi commented Jun 20, 2022

Signed-off-by: mingzhou.swx mingzhou.swx@alibaba-inc.com

Ⅰ. Describe what this PR does

Add switch for PersistentPodState controller

Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
@kruise-bot kruise-bot requested review from FillZpp and furykerry June 20, 2022 02:07
@kruise-bot kruise-bot added the size/XS size/XS: 0-9 label Jun 20, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1002 (5401210) into master (54043e5) will increase coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1002      +/-   ##
==========================================
+ Coverage   49.07%   49.12%   +0.04%     
==========================================
  Files         125      125              
  Lines       12060    12062       +2     
==========================================
+ Hits         5918     5925       +7     
+ Misses       5237     5234       -3     
+ Partials      905      903       -2     
Flag Coverage Δ
unittests 49.12% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sistentpodstate/persistent_pod_state_controller.go 31.10% <0.00%> (-0.31%) ⬇️
pkg/controller/uniteddeployment/revision.go 67.93% <0.00%> (+1.52%) ⬆️
pkg/controller/cloneset/cloneset_controller.go 54.15% <0.00%> (+1.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54043e5...5401210. Read the comment docs.

@zmberg
Copy link
Member

zmberg commented Jun 20, 2022

/lgtm

@FillZpp
Copy link
Member

FillZpp commented Jun 20, 2022

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 345c292 into openkruise:master Jun 20, 2022
FillZpp pushed a commit that referenced this pull request Jun 20, 2022
Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>

Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
diannaowa pushed a commit to diannaowa/kruise that referenced this pull request Sep 14, 2022
Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>

Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants