Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize CloneSet queuing when cache has just synced #1026

Merged

Conversation

FillZpp
Copy link
Member

@FillZpp FillZpp commented Jul 15, 2022

Signed-off-by: FillZpp FillZpp.pub@gmail.com

Ⅰ. Describe what this PR does

Optimize CloneSet queuing when cache has just synced.

@kruise-bot kruise-bot added the size/S size/S 10-29 label Jul 15, 2022
if isSatisfied {
// If the scale expectation is satisfied, it should be an existing Pod and the Informer
// cache should have just synced.
q.AddAfter(*req, e.initialingRateLimiter.When(req))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add same logic to pvc event handler

Signed-off-by: FillZpp <FillZpp.pub@gmail.com>
@FillZpp FillZpp force-pushed the optimize-cloneset-queuing-when-starting branch from 59107b4 to b93ebff Compare July 15, 2022 10:29
@kruise-bot kruise-bot added size/M size/M: 30-99 and removed size/S size/S 10-29 labels Jul 15, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1026 (b93ebff) into master (2ade07a) will increase coverage by 0.01%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master    #1026      +/-   ##
==========================================
+ Coverage   49.66%   49.67%   +0.01%     
==========================================
  Files         124      124              
  Lines       12078    12088      +10     
==========================================
+ Hits         5998     6005       +7     
- Misses       5164     5165       +1     
- Partials      916      918       +2     
Flag Coverage Δ
unittests 49.67% <75.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/cloneset/cloneset_event_handler.go 78.68% <75.00%> (-0.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ade07a...b93ebff. Read the comment docs.

Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@FillZpp
Copy link
Member Author

FillZpp commented Jul 15, 2022

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 58713b5 into openkruise:master Jul 15, 2022
@FillZpp FillZpp added this to the v1.3.0 milestone Jul 21, 2022
diannaowa pushed a commit to diannaowa/kruise that referenced this pull request Sep 14, 2022
Signed-off-by: FillZpp <FillZpp.pub@gmail.com>
Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants