-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize CloneSet queuing when cache has just synced #1026
Optimize CloneSet queuing when cache has just synced #1026
Conversation
if isSatisfied { | ||
// If the scale expectation is satisfied, it should be an existing Pod and the Informer | ||
// cache should have just synced. | ||
q.AddAfter(*req, e.initialingRateLimiter.When(req)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should add same logic to pvc event handler
Signed-off-by: FillZpp <FillZpp.pub@gmail.com>
59107b4
to
b93ebff
Compare
Codecov Report
@@ Coverage Diff @@
## master #1026 +/- ##
==========================================
+ Coverage 49.66% 49.67% +0.01%
==========================================
Files 124 124
Lines 12078 12088 +10
==========================================
+ Hits 5998 6005 +7
- Misses 5164 5165 +1
- Partials 916 918 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FillZpp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: FillZpp <FillZpp.pub@gmail.com> Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
Signed-off-by: FillZpp FillZpp.pub@gmail.com
Ⅰ. Describe what this PR does
Optimize CloneSet queuing when cache has just synced.