Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add resourcedistribution generator proposal #1029

Closed
wants to merge 1 commit into from

Conversation

dong4325
Copy link

Ⅰ. Describe what this PR does

Add proposal for ResourceDistributionGenerator

Ⅱ. Does this pull request fix one issue?

fixes #943

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign fillzpp after the PR has been reviewed.
You can assign the PR to them by writing /assign @fillzpp in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot
Copy link

Welcome @dong4325! It looks like this is your first PR to openkruise/kruise 🎉

@kruise-bot kruise-bot added the size/L size/L: 100-499 label Jul 17, 2022
@veophi veophi requested review from zmberg, veophi, furykerry and hantmac and removed request for Fei-Guo July 19, 2022 02:34
@dong4325 dong4325 force-pushed the master branch 3 times, most recently from 19b3eab to b26779b Compare July 19, 2022 09:41
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2022

Codecov Report

Merging #1029 (1fc14eb) into master (af222ee) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1029      +/-   ##
==========================================
+ Coverage   49.26%   49.29%   +0.03%     
==========================================
  Files         125      125              
  Lines       12341    12341              
==========================================
+ Hits         6080     6084       +4     
+ Misses       5321     5319       -2     
+ Partials      940      938       -2     
Flag Coverage Δ
unittests 49.29% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/daemonset/daemonset_update.go 54.86% <0.00%> (-0.89%) ⬇️
pkg/controller/cloneset/cloneset_controller.go 56.52% <0.00%> (+2.37%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.


### Weakness

Using the go plugin requires that the main program and the plugin program have the same build environment. So, End users using shared plugins must compile both kustomize and plugin.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to use the Containerized KRM Function method? Does this mean that the user does not need to compile extra

@dong4325 dong4325 force-pushed the master branch 2 times, most recently from 1fc14eb to bb28a60 Compare August 8, 2022 04:35
@dong4325 dong4325 requested review from hantmac and zmberg and removed request for FillZpp, veophi, furykerry, hantmac and zmberg August 27, 2022 09:57
@dong4325 dong4325 force-pushed the master branch 2 times, most recently from b722f24 to 025e94c Compare August 30, 2022 09:53
Signed-off-by: dong <dong4325@126.com>
@stale
Copy link

stale bot commented Nov 28, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Nov 28, 2022
@stale stale bot closed this Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L size/L: 100-499 wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request]ResourceDistribution should consider configmapGenerator
5 participants