Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1045 specifies the kruise-manager client accept protobuf first #1045

Closed
wants to merge 1 commit into from

Conversation

hatowang
Copy link
Contributor

@hatowang hatowang commented Aug 2, 2022

Ⅰ. Describe what this PR does

Improve performance by replacing json with protobuf.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign furykerry after the PR has been reviewed.
You can assign the PR to them by writing /assign @furykerry in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot added the size/XS size/XS: 0-9 label Aug 2, 2022
@hatowang hatowang changed the title specifies the kruise-manager client accept protobuf first #1045 specifies the kruise-manager client accept protobuf first Aug 2, 2022
Signed-off-by: hatowang <wyyharo@163.com>
@FillZpp
Copy link
Member

FillZpp commented Aug 2, 2022

There is no need to do this, controller-runtime will automatically choose protobuf for built-in types since v0.7.0 kubernetes-sigs/controller-runtime#1149

@codecov-commenter
Copy link

Codecov Report

Merging #1045 (128d891) into master (af222ee) will not change coverage.
The diff coverage is n/a.

❗ Current head 128d891 differs from pull request most recent head 70c2c8a. Consider uploading reports for the commit 70c2c8a to get more accurate results

@@           Coverage Diff           @@
##           master    #1045   +/-   ##
=======================================
  Coverage   49.26%   49.26%           
=======================================
  Files         125      125           
  Lines       12341    12341           
=======================================
  Hits         6080     6080           
  Misses       5321     5321           
  Partials      940      940           
Flag Coverage Δ
unittests 49.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us.

@hatowang
Copy link
Contributor Author

hatowang commented Aug 2, 2022

There is no need to do this, controller-runtime will automatically choose protobuf for built-in types since v0.7.0 kubernetes-sigs/controller-runtime#1149

so good for me!

@hatowang hatowang closed this Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS size/XS: 0-9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants