-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workloadspread support statefulset #1056
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1056 +/- ##
==========================================
- Coverage 49.30% 49.02% -0.28%
==========================================
Files 125 125
Lines 12355 12466 +111
==========================================
+ Hits 6092 6112 +20
- Misses 5322 5412 +90
- Partials 941 942 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
177dc30
to
7c0e3de
Compare
e323d36
to
3f15da2
Compare
Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FillZpp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
Signed-off-by: mingzhou.swx mingzhou.swx@alibaba-inc.com
Ⅰ. Describe what this PR does
StatefulSet has special logic about pod assignment for subsets. For example, suppose that we have the following sub sets config:
the pods with order within [0, 5) will be assigned to subset-a;
the pods with order within [5, 10) will be assigned to subset-b;
the pods with order within [10, inf) will be assigned to subset-c.
Note:
subset[x].maxReplicas
for all StatefulSet;