Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store historical patchPodMetadata field for SidecarSet #1059

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

veophi
Copy link
Member

@veophi veophi commented Aug 17, 2022

Signed-off-by: mingzhou.swx mingzhou.swx@alibaba-inc.com

Ⅰ. Describe what this PR does

  1. store history patchPodMetadata field for SidecarSet;
  2. make sidecar injection logic more robust;

@kruise-bot kruise-bot added the size/S size/S 10-29 label Aug 17, 2022
@veophi veophi changed the title Store history patchPodMetadata field for SidecarSet Store historical patchPodMetadata field for SidecarSet Aug 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2022

Codecov Report

Merging #1059 (d6a6472) into master (fc174ab) will increase coverage by 0.16%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1059      +/-   ##
==========================================
+ Coverage   49.36%   49.52%   +0.15%     
==========================================
  Files         125      125              
  Lines       12363    12422      +59     
==========================================
+ Hits         6103     6152      +49     
- Misses       5319     5326       +7     
- Partials      941      944       +3     
Flag Coverage Δ
unittests 49.52% <0.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/control/sidecarcontrol/history_control.go 0.00% <0.00%> (ø)
pkg/webhook/pod/mutating/sidecarset.go 63.15% <0.00%> (-0.56%) ⬇️
pkg/util/workloadspread/workloadspread.go 59.02% <0.00%> (-2.94%) ⬇️
...troller/workloadspread/update_pod_deletion_cost.go 63.41% <0.00%> (-0.59%) ⬇️
...roller/workloadspread/workloadspread_controller.go 62.72% <0.00%> (ø)
...loadspread/validating/workloadspread_validation.go 76.35% <0.00%> (+1.88%) ⬆️
...ler/workloadspread/workloadspread_event_handler.go 80.18% <0.00%> (+18.56%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zmberg
Copy link
Member

zmberg commented Aug 17, 2022

/lgtm

@veophi veophi force-pushed the sidecar-revision-fix branch from 47a73ce to c6322b2 Compare August 18, 2022 03:43
@kruise-bot kruise-bot added size/M size/M: 30-99 and removed lgtm size/S size/S 10-29 labels Aug 18, 2022
Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
@veophi veophi force-pushed the sidecar-revision-fix branch from c6322b2 to d6a6472 Compare August 18, 2022 03:47
@veophi veophi requested a review from zmberg August 18, 2022 03:51
@zmberg
Copy link
Member

zmberg commented Aug 18, 2022

/lgtm

@FillZpp
Copy link
Member

FillZpp commented Aug 18, 2022

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 528ab12 into openkruise:master Aug 18, 2022
diannaowa pushed a commit to diannaowa/kruise that referenced this pull request Sep 14, 2022
Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>

Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants