Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sidecar container exit priority proposal #1112

Closed
wants to merge 1 commit into from
Closed

sidecar container exit priority proposal #1112

wants to merge 1 commit into from

Conversation

zmberg
Copy link
Member

@zmberg zmberg commented Oct 27, 2022

Signed-off-by: liheng.zms liheng.zms@alibaba-inc.com

Ⅰ. Describe what this PR does

sidecar container exit priority proposal.

@kruise-bot kruise-bot added the size/L size/L: 100-499 label Oct 27, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2022 •
edited by codecov bot

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a639a6f) 49.30% compared to head (7693700) 55.20%.
Report is 143 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1112      +/-   ##
==========================================
+ Coverage   49.30%   55.20%   +5.90%     
==========================================
  Files         137      154      +17     
  Lines       19299    25122    +5823     
==========================================
+ Hits         9515    13869    +4354     
- Misses       8732    10059    +1327     
- Partials     1052     1194     +142
Flag Coverage Δ
unittests 55.20% <ø> (+5.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zmberg zmberg force-pushed the sidecar-exit-priority-proposal branch from 12968cd to fc2e974 Compare October 27, 2022 05:43
@zmberg
sidecar container exit priority proposal
7693700 
Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
@zmberg zmberg force-pushed the sidecar-exit-priority-proposal branch from fc2e974 to 7693700 Compare October 27, 2022 05:44
@zmberg zmberg mentioned this pull request Jan 5, 2023
Open
@zmberg zmberg added this to In progress in Roadmap via automation Jan 5, 2023
@zmberg zmberg added this to the v1.4 milestone Jan 5, 2023
@zmberg zmberg self-assigned this Jan 5, 2023
@zmberg zmberg moved this from In progress to Proposal in Roadmap Jan 5, 2023
@zmberg zmberg moved this from Proposal to In progress in Roadmap Jan 5, 2023
@zmberg zmberg removed this from In progress in Roadmap Jan 5, 2023
@zmberg zmberg removed this from the v1.4 milestone Jan 5, 2023
@stale
Copy link

stale bot commented Apr 5, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 5, 2023
@stale stale bot closed this Apr 17, 2023
@zmberg zmberg reopened this Apr 18, 2023
@stale stale bot removed the wontfix This will not be worked on label Apr 18, 2023
@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from zmberg by writing /assign @zmberg in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stale
Copy link

stale bot commented Jul 17, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jul 17, 2023
@stale stale bot closed this Jul 24, 2023
@zmberg zmberg reopened this Jul 25, 2023
@stale stale bot removed the wontfix This will not be worked on label Jul 25, 2023
@stale
Copy link

stale bot commented Oct 23, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Oct 23, 2023
@stale stale bot closed this Nov 1, 2023
@zmberg zmberg reopened this Nov 1, 2023
@stale stale bot removed the wontfix This will not be worked on label Nov 1, 2023
@stale Stale
Copy link

stale bot commented Jan 30, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jan 30, 2024
@stale stale bot closed this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FillZpp FillZpp Awaiting requested review from FillZpp

@furykerry furykerry Awaiting requested review from furykerry

Assignees

@zmberg zmberg

Labels
size/L size/L: 100-499 wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zmberg @codecov-commenter @kruise-bot