-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WorkloadSpread support workload rolling update case #1197
Conversation
32e9dbe
to
765d8af
Compare
👍 |
765d8af
to
9e5b14f
Compare
0716f5b
to
70a358f
Compare
build from
|
70a358f
to
28d7382
Compare
@guhan121 fixed. |
dd4b6d1
to
0c194db
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1197 +/- ##
==========================================
+ Coverage 48.35% 48.63% +0.28%
==========================================
Files 154 154
Lines 21663 21892 +229
==========================================
+ Hits 10475 10648 +173
- Misses 10037 10082 +45
- Partials 1151 1162 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0c194db
to
8fb904d
Compare
8fb904d
to
0d32231
Compare
0d32231
to
bcfb493
Compare
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
bcfb493
to
84bc98a
Compare
34f39cf
to
1ce2978
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plz add missing unit tests, especially for. pkg/util/workloadspread/workloadspread.go
Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
1ce2978
to
15a67e3
Compare
done @furykerry |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zmberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
Ⅰ. Describe what this PR does
WorkloadSpread support rolling update via versioned subset statuses.
Ⅱ. Does this pull request fix one issue?
#1194. #834
Ⅲ. Describe how to verify it
e2e and ut