Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize CloneSet event handler codes #1219

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

veophi
Copy link
Member

@veophi veophi commented Mar 13, 2023

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot added the size/L size/L: 100-499 label Mar 13, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1219 (5278f75) into master (e70c146) will increase coverage by 0.11%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #1219      +/-   ##
==========================================
+ Coverage   49.99%   50.11%   +0.11%     
==========================================
  Files         143      143              
  Lines       19843    19872      +29     
==========================================
+ Hits         9921     9958      +37     
+ Misses       8834     8818      -16     
- Partials     1088     1096       +8     
Flag Coverage Δ
unittests 50.11% <0.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/cloneset/cloneset_event_handler.go 66.36% <0.00%> (+7.01%) ⬆️

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
@zmberg
Copy link
Member

zmberg commented Mar 14, 2023

/lgtm

@zmberg
Copy link
Member

zmberg commented Mar 14, 2023

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 6927036 into openkruise:master Mar 14, 2023
diannaowa pushed a commit to diannaowa/kruise that referenced this pull request Jun 2, 2023
Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
diannaowa pushed a commit to diannaowa/kruise that referenced this pull request Jun 2, 2023
Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants