Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: initContainers shareVolumePolicy is not effective #1229

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

y-ykcir
Copy link
Contributor

@y-ykcir y-ykcir commented Mar 20, 2023

Ⅰ. Describe what this PR does

fix initContainers shareVolumePolicy is not effective

Ⅱ. Does this pull request fix one issue?

fix #1216

Ⅲ. Describe how to verify it

Refer to the issue

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot requested review from Fei-Guo and FillZpp March 20, 2023 02:28
@kruise-bot
Copy link

Welcome @y-ykcir! It looks like this is your first PR to openkruise/kruise 🎉

@kruise-bot kruise-bot added the size/S size/S 10-29 label Mar 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2023

Codecov Report

Merging #1229 (3ca4593) into master (8204954) will increase coverage by 0.06%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #1229      +/-   ##
==========================================
+ Coverage   50.21%   50.28%   +0.06%     
==========================================
  Files         143      143              
  Lines       19850    19846       -4     
==========================================
+ Hits         9968     9979      +11     
+ Misses       8786     8773      -13     
+ Partials     1096     1094       -2     
Flag Coverage Δ
unittests 50.28% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/webhook/pod/mutating/sidecarset.go 69.77% <100.00%> (+0.96%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@y-ykcir y-ykcir force-pushed the fix-sharevolumepolicy branch from a0efa0f to 443c89b Compare March 20, 2023 04:04
@furykerry furykerry requested review from zmberg and removed request for FillZpp and Fei-Guo March 21, 2023 10:03
@zmberg
Copy link
Member

zmberg commented Mar 23, 2023

@y-ykcir good, can you add some ut in code?

@y-ykcir
Copy link
Contributor Author

y-ykcir commented Mar 23, 2023

@y-ykcir good, can you add some ut in code?

ok, I'll add some ut.

Signed-off-by: ricky <yricky509@gmail.com>
@y-ykcir y-ykcir force-pushed the fix-sharevolumepolicy branch from 443c89b to 3ca4593 Compare March 23, 2023 07:08
@kruise-bot kruise-bot added size/M size/M: 30-99 and removed size/S size/S 10-29 labels Mar 23, 2023
@y-ykcir
Copy link
Contributor Author

y-ykcir commented Mar 23, 2023

@zmberg PTAL

@zmberg
Copy link
Member

zmberg commented Mar 24, 2023

/lgtm

@zmberg
Copy link
Member

zmberg commented Mar 27, 2023

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 1d1a54a into openkruise:master Mar 27, 2023
@y-ykcir y-ykcir deleted the fix-sharevolumepolicy branch March 27, 2023 05:46
kevin1689-cloud pushed a commit to kevin1689-cloud/kruise that referenced this pull request Mar 31, 2023
Signed-off-by: ricky <yricky509@gmail.com>
kevin1689-cloud pushed a commit to kevin1689-cloud/kruise that referenced this pull request Apr 1, 2023
Signed-off-by: ricky <yricky509@gmail.com>
diannaowa pushed a commit to diannaowa/kruise that referenced this pull request Jun 2, 2023
Signed-off-by: ricky <yricky509@gmail.com>
diannaowa pushed a commit to diannaowa/kruise that referenced this pull request Jun 2, 2023
Signed-off-by: ricky <yricky509@gmail.com>
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] initContainers shareVolumePolicy is not effective
4 participants