feat: Optimize UnitedDeployment replicas settings #1247
Conversation
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| } | ||
| } else if count != len(spec.Topology.Subsets) { | ||
| // validate all of subsets replicas are not nil | ||
| allErrs = append(allErrs, field.Invalid(fldPath.Child("topology", "subsets"), sumReplicas, fmt.Sprintf("if UnitedDeployment replicas is not provided, replicas of all subsets should be provided"))) |
There was a problem hiding this comment.
S1039: unnecessary use of fmt.Sprintf
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Help us improve LIFT! (Sonatype LiftBot external survey)
Was this a good recommendation for you? Answering this survey will not impact your Lift settings.
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
Signed-off-by: ricky <yricky509@gmail.com>
|
@veophi PTAL |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zmberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: ricky <yricky509@gmail.com>
Signed-off-by: ricky <yricky509@gmail.com>
Ⅰ. Describe what this PR does
Optimize UnitedDeployment replicas settings:
add optimization for the situation when
spec.replicasis not set (nil)Ⅱ. Does this pull request fix one issue?
fixed #1220
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews