Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proposal of UnitedDeployment Patch #1265

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

chengleqi
Copy link
Contributor

Ⅰ. Describe what this PR does

Add proposal of UnitedDeployment Patch.
Users can use patch to configure template resources differentially in subsets.

@kruise-bot kruise-bot added the size/M size/M: 30-99 label Apr 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2023

Codecov Report

Merging #1265 (cdfc5df) into master (7d134bf) will decrease coverage by 0.03%.
The diff coverage is 24.24%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1265      +/-   ##
==========================================
- Coverage   48.60%   48.58%   -0.03%     
==========================================
  Files         151      151              
  Lines       21005    21028      +23     
==========================================
+ Hits        10210    10216       +6     
- Misses       9680     9697      +17     
  Partials     1115     1115              
Flag Coverage Δ
unittests 48.58% <24.24%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontroller/daemonset/daemonset_predownload_image.go 0.00% <0.00%> (ø)
pkg/controller/sidecarset/sidecarset_processor.go 67.78% <0.00%> (-0.83%) ⬇️
...oller/statefulset/statefulset_predownload_image.go 0.00% <0.00%> (ø)
.../controller/cloneset/cloneset_predownload_image.go 62.80% <88.88%> (+1.94%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: chengleqi <chengleqi5g@hotmail.com>

fix markdownlint-misspell

Signed-off-by: chengleqi <chengleqi5g@hotmail.com>

fix typo in patch resource sample

Signed-off-by: chengleqi <chengleqi5g@hotmail.com>
@zmberg zmberg added this to the v1.5 milestone Jun 8, 2023
@zmberg zmberg added this to In progress in Roadmap via automation Jun 8, 2023
@zmberg
Copy link
Member

zmberg commented Sep 7, 2023

/lgtm

@zmberg
Copy link
Member

zmberg commented Sep 7, 2023

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit a46e941 into openkruise:master Sep 7, 2023
23 checks passed
Roadmap automation moved this from In progress to Done Sep 7, 2023
lilongfeng0902 pushed a commit to lilongfeng0902/kruise that referenced this pull request Sep 12, 2023
fix markdownlint-misspell

fix typo in patch resource sample

Signed-off-by: chengleqi <chengleqi5g@hotmail.com>

put in constant parameters

Signed-off-by: 李龙峰 <lilongfeng@inspur.com>
lilongfeng0902 pushed a commit to lilongfeng0902/kruise that referenced this pull request Sep 12, 2023
Signed-off-by: 李龙峰 <lilongfeng@inspur.com>

Add proposal of UnitedDeployment Patch (openkruise#1265)

fix markdownlint-misspell

fix typo in patch resource sample

Signed-off-by: chengleqi <chengleqi5g@hotmail.com>

put in constant parameters

Signed-off-by: 李龙峰 <lilongfeng@inspur.com>

put in constant parameters

Signed-off-by: 李龙峰 <lilongfeng@inspur.com>

fallback log level

Signed-off-by: 李龙峰 <lilongfeng@inspur.com>
lilongfeng0902 pushed a commit to lilongfeng0902/kruise that referenced this pull request Sep 12, 2023
fix markdownlint-misspell



fix typo in patch resource sample

Signed-off-by: chengleqi <chengleqi5g@hotmail.com>
@zmberg zmberg modified the milestones: v1.5, 1.6 Mar 7, 2024
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
fix markdownlint-misspell



fix typo in patch resource sample
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Roadmap
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants