Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue of missing Pods in pub list function #1274

Merged
merged 1 commit into from
May 8, 2023

Conversation

zmberg
Copy link
Member

@zmberg zmberg commented May 5, 2023

Ⅰ. Describe what this PR does

Pub List Deployment pods have been missing during the process of rolling update for Deployment.

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
@kruise-bot kruise-bot added the size/XS size/XS: 0-9 label May 5, 2023
@veophi
Copy link
Member

veophi commented May 5, 2023

/lgtm

@codecov-commenter
Copy link

Codecov Report

Merging #1274 (d6b95ed) into master (7f5046d) will increase coverage by 0.01%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #1274      +/-   ##
==========================================
+ Coverage   48.45%   48.46%   +0.01%     
==========================================
  Files         149      149              
  Lines       20627    20627              
==========================================
+ Hits         9994     9997       +3     
+ Misses       9537     9535       -2     
+ Partials     1096     1095       -1     
Flag Coverage Δ
unittests 48.46% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@zmberg
Copy link
Member Author

zmberg commented May 8, 2023

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 437ba70 into openkruise:master May 8, 2023
@zmberg zmberg deleted the fix-pub-bug branch May 8, 2023 06:06
diannaowa pushed a commit to diannaowa/kruise that referenced this pull request Jun 2, 2023
Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
diannaowa pushed a commit to diannaowa/kruise that referenced this pull request Jun 2, 2023
Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
lilongfeng0902 pushed a commit to lilongfeng0902/kruise that referenced this pull request Sep 12, 2023
Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants