Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge the update requests of status and extra status for CloneSet #1278

Merged
merged 1 commit into from
May 15, 2023

Conversation

veophi
Copy link
Member

@veophi veophi commented May 8, 2023

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot added the size/M size/M: 30-99 label May 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 8, 2023

Codecov Report

Merging #1278 (32e14c3) into master (ccd94b2) will decrease coverage by 0.01%.
The diff coverage is 68.75%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1278      +/-   ##
==========================================
- Coverage   48.53%   48.53%   -0.01%     
==========================================
  Files         149      149              
  Lines       20616    20625       +9     
==========================================
+ Hits        10007    10010       +3     
- Misses       9514     9518       +4     
- Partials     1095     1097       +2     
Flag Coverage Δ
unittests 48.53% <68.75%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/cloneset/cloneset_status.go 85.71% <68.75%> (-3.18%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@zmberg
Copy link
Member

zmberg commented May 9, 2023

/lgtm

Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
@furykerry
Copy link
Member

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zmberg
Copy link
Member

zmberg commented May 15, 2023

/lgtm

@kruise-bot kruise-bot merged commit 210d870 into openkruise:master May 15, 2023
diannaowa pushed a commit to diannaowa/kruise that referenced this pull request Jun 2, 2023
…ise#1278)

Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
diannaowa pushed a commit to diannaowa/kruise that referenced this pull request Jun 2, 2023
…ise#1278)

Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
lilongfeng0902 pushed a commit to lilongfeng0902/kruise that referenced this pull request Sep 12, 2023
…ise#1278)

Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
…ise#1278)

Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants