-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the issue of dependencies failing to pull in the Dockerfile. #1279
Conversation
Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
@@ -23,7 +23,7 @@ ARG BASE_IMAGE | |||
ARG BASE_IMAGE_VERSION | |||
FROM ${BASE_IMAGE}:${BASE_IMAGE_VERSION} | |||
|
|||
RUN apk add --no-cache ca-certificates=~20220614-r4 bash=~5.2.15-r0 expat=~2.5.0-r0 \ | |||
RUN apk add --no-cache ca-certificates bash expat \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DL3018: Pin versions in apk add. Instead of apk add <package>
use apk add <package>=<version>
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
Command | Usage |
---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sonatype-lift ignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've recorded this as ignored for this pull request.
If you change your mind, just comment @sonatype-lift unignore
.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #1279 +/- ##
=======================================
Coverage 48.45% 48.45%
=======================================
Files 149 149
Lines 20627 20627
=======================================
Hits 9994 9994
Misses 9537 9537
Partials 1096 1096
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furykerry The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…nkruise#1279) Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
…nkruise#1279) Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
…nkruise#1279) Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
Ⅰ. Describe what this PR does
Fix the issue of dependencies failing to pull in the Dockerfile.