update the image status when start pulling images #1280
Conversation
diannaowa
force-pushed
the
fix_1273
branch
2 times, most recently
from
33fb4dd
to
0026f1a
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1280 +/- ##
==========================================
+ Coverage 48.45% 48.48% +0.03%
==========================================
Files 149 149
Lines 20627 20614 -13
==========================================
Hits 9994 9994
+ Misses 9537 9523 -14
- Partials 1096 1097 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
got it, thanks for reminding |
…defaultDomain and officialRepoName) name and tag of image Signed-off-by: liuzhenwei <dui_zhang@163.com> add ut for ContainsImage Signed-off-by: liuzhenwei <dui_zhang@163.com> revert import Signed-off-by: liuzhenwei <dui_zhang@163.com>
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zmberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…defaultDomain and officialRepoName) name and tag of image (openkruise#1280) add ut for ContainsImage revert import Signed-off-by: liuzhenwei <dui_zhang@163.com>
…defaultDomain and officialRepoName) name and tag of image (openkruise#1280) add ut for ContainsImage revert import Signed-off-by: liuzhenwei <dui_zhang@163.com>
…defaultDomain and officialRepoName) name and tag of image (openkruise#1280) add ut for ContainsImage revert import Signed-off-by: liuzhenwei <dui_zhang@163.com>
…defaultDomain and officialRepoName) name and tag of image (openkruise#1280) add ut for ContainsImage revert import
Ⅰ. Describe what this PR does
We should update the image status when we start pulling images,
which can meet the scenario that some large size images cannot return the result from CRI.PullImage within 60s. For one reason:
1.For nodeimage controller will mark image:tag task failed (not responded for a long time) if daemon does not report status in 60s.
When checking whether a image exists, we should compare the name(without defaultDomain and officialRepoName) and tag of the image.
Ⅱ. Does this pull request fix one issue?
fixes #1273
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews