Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize the situation where the ImageID remains unchanged but changing the Tag for in-place upgrades #1284

Closed
wants to merge 3 commits into from

Conversation

diannaowa
Copy link
Contributor

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #1242

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fillzpp for approval by writing /assign @fillzpp in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot added the size/M size/M: 30-99 label May 15, 2023
@diannaowa diannaowa changed the title Feat 1242 optimize the situation where the ImageID remains unchanged but changing the Tag for in-place upgrades May 15, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1284 (bab03e4) into master (54079d1) will decrease coverage by 1.56%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1284      +/-   ##
==========================================
- Coverage   50.04%   48.49%   -1.56%     
==========================================
  Files         143      149       +6     
  Lines       19898    20622     +724     
==========================================
+ Hits         9958    10000      +42     
- Misses       8844     9525     +681     
- Partials     1096     1097       +1     
Flag Coverage Δ
unittests 48.49% <100.00%> (-1.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/control/sidecarcontrol/sidecarset_control.go 40.96% <100.00%> (+1.08%) ⬆️
pkg/util/inplaceupdate/inplace_update_defaults.go 64.39% <100.00%> (+0.11%) ⬆️

... and 31 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: liuzhenwei <dui_zhang@163.com>
@kruise-bot
Copy link

@diannaowa: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kruise-bot kruise-bot added size/L size/L: 100-499 and removed size/M size/M: 30-99 labels May 16, 2023
Signed-off-by: liuzhenwei <dui_zhang@163.com>
Signed-off-by: liuzhenwei <dui_zhang@163.com>
@diannaowa diannaowa closed this May 16, 2023
@@ -346,6 +357,9 @@ func (c *Controller) manageContainerMetaSet(pod *v1.Pod, kubePodStatus *kubeletc
Hashes: appspub.RuntimeContainerHashes{PlainHash: status.Hash},
}
}
if imageID != "" {
containerMeta.ImageID = imageID
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

28% of developers fix this issue

typecheck: containerMeta.ImageID undefined (type *pub.RuntimeContainerMeta has no field or method ImageID)


ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants