adding updatedAvailableReplicas field #1317

nitishchauhan0022 · 2023-06-16T15:56:17Z

Ⅰ. Describe what this PR does

Added updatedAvailableReplicas field to CloneSet and Advanced StatefulSet

Ⅱ. Does this pull request fix one issue?

codecov-commenter · 2023-06-16T16:08:13Z

Codecov Report

Merging #1317 (929d489) into master (ffcf189) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1317      +/-   ##
==========================================
+ Coverage   48.50%   48.55%   +0.04%     
==========================================
  Files         151      152       +1     
  Lines       21210    21246      +36     
==========================================
+ Hits        10288    10316      +28     
- Misses       9793     9801       +8     
  Partials     1129     1129

Flag	Coverage Δ
unittests	`48.55% <100.00%> (+0.04%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/controller/cloneset/cloneset_status.go	`89.83% <100.00%> (+0.73%)`	⬆️
pkg/controller/statefulset/stateful_set_control.go	`63.42% <100.00%> (+0.10%)`	⬆️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

pkg/controller/cloneset/cloneset_status.go

Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com>

zmberg · 2023-06-25T09:04:23Z

@nitishchauhan0022 You must exec make build & make manifests, and push again.

nitishchauhan0022 · 2023-06-25T18:11:27Z

@zmberg I did it before pushing, and I tried again now, but no changes were observed.

zmberg · 2023-06-26T07:33:48Z

pkg/controller/statefulset/stateful_set_control.go

@@ -403,6 +403,9 @@ func (ssc *defaultStatefulSetControl) updateStatefulSet(
 			status.ReadyReplicas++
 			if getPodRevision(pods[i]) == updateRevision.Name {
 				status.UpdatedReadyReplicas++
+				if avail, _ := isRunningAndAvailable(pods[i], minReadySeconds); avail {
+					status.UpdatedAvailableReplicas++
+				}


File have many checks for set.Status.UpdatedReplicas, and i think you can add UpdatedAvailableReplicas checks.

zmberg · 2023-06-26T12:04:40Z

Run [[ -z $(git status -s) ]] || (printf "Existing modified/untracked files.\nPlease run \"make generate manifests\" and push again.\n"; exit 1)
Existing modified/untracked files.
Please run "make generate manifests" and push again.
Error: Process completed with exit code 1.

What is your go version? Preferably 1.18.

pkg/client/clientset/versioned/fake/register.go

nitishchauhan0022 · 2023-06-27T08:03:21Z

Run [[ -z $(git status -s) ]] || (printf "Existing modified/untracked files.\nPlease run \"make generate manifests\" and push again.\n"; exit 1)
Existing modified/untracked files.
Please run "make generate manifests" and push again.
Error: Process completed with exit code 1.

What is your go version? Preferably 1.18.

1.20.5

zmberg · 2023-07-04T03:16:52Z

@nitishchauhan0022 Can you join kruise dingding to communicate with me?

Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com>

pkg/controller/statefulset/stateful_set_control_test.go

Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com>

zmberg · 2023-07-05T03:36:09Z

/lgtm

zmberg · 2023-07-06T02:15:02Z

/approve

kruise-bot · 2023-07-06T02:15:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [zmberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* adding updatedAvailableReplicas field Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com> * resolving linting error and some check for updatedavailabel replica Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com> * fixing typo Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com> --------- Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com>

* adding updatedAvailableReplicas field * resolving linting error and some check for updatedavailabel replica * fixing typo ---------

kruise-bot requested review from FillZpp and shiyan2016 June 16, 2023 15:56

kruise-bot added the size/M size/M: 30-99 label Jun 16, 2023

nitishchauhan0022 force-pushed the updated-replica branch from 9a9117c to 01ae904 Compare June 16, 2023 16:07

sonatype-lift bot reviewed Jun 16, 2023

View reviewed changes

pkg/controller/cloneset/cloneset_status.go Show resolved Hide resolved

sonatype-lift bot reviewed Jun 16, 2023

View reviewed changes

pkg/controller/cloneset/cloneset_status.go Show resolved Hide resolved

adding updatedAvailableReplicas field

843f5c7

Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com>

nitishchauhan0022 force-pushed the updated-replica branch from 01ae904 to 843f5c7 Compare June 16, 2023 16:16

zmberg reviewed Jun 26, 2023

View reviewed changes

zmberg reviewed Jun 27, 2023

View reviewed changes

pkg/client/clientset/versioned/fake/register.go Outdated Show resolved Hide resolved

resolving linting error and some check for updatedavailabel replica

72e889b

Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com>

zmberg reviewed Jul 4, 2023

View reviewed changes

pkg/controller/statefulset/stateful_set_control_test.go Outdated Show resolved Hide resolved

fixing typo

929d489

Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com>

kruise-bot assigned zmberg Jul 5, 2023

kruise-bot added the lgtm label Jul 5, 2023

kruise-bot added the approved label Jul 6, 2023

kruise-bot merged commit 24a4b7f into openkruise:master Jul 6, 2023

ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024

adding updatedAvailableReplicas field (openkruise#1317)

79f3d2b

* adding updatedAvailableReplicas field * resolving linting error and some check for updatedavailabel replica * fixing typo ---------

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adding updatedAvailableReplicas field #1317

adding updatedAvailableReplicas field #1317

nitishchauhan0022 commented Jun 16, 2023

codecov-commenter commented Jun 16, 2023 •

edited

Loading

zmberg commented Jun 25, 2023

nitishchauhan0022 commented Jun 25, 2023

zmberg Jun 26, 2023

zmberg commented Jun 26, 2023 •

edited

Loading

nitishchauhan0022 commented Jun 27, 2023

zmberg commented Jul 4, 2023

zmberg commented Jul 5, 2023

zmberg commented Jul 6, 2023

kruise-bot commented Jul 6, 2023

adding updatedAvailableReplicas field #1317

adding updatedAvailableReplicas field #1317

Conversation

nitishchauhan0022 commented Jun 16, 2023

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

codecov-commenter commented Jun 16, 2023 • edited Loading

Codecov Report

zmberg commented Jun 25, 2023

nitishchauhan0022 commented Jun 25, 2023

zmberg Jun 26, 2023

Choose a reason for hiding this comment

zmberg commented Jun 26, 2023 • edited Loading

nitishchauhan0022 commented Jun 27, 2023

zmberg commented Jul 4, 2023

zmberg commented Jul 5, 2023

zmberg commented Jul 6, 2023

kruise-bot commented Jul 6, 2023

codecov-commenter commented Jun 16, 2023 •

edited

Loading

zmberg commented Jun 26, 2023 •

edited

Loading