-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding updatedAvailableReplicas field #1317
adding updatedAvailableReplicas field #1317
Conversation
9a9117c
to
01ae904
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1317 +/- ##
==========================================
+ Coverage 48.50% 48.55% +0.04%
==========================================
Files 151 152 +1
Lines 21210 21246 +36
==========================================
+ Hits 10288 10316 +28
- Misses 9793 9801 +8
Partials 1129 1129
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com>
01ae904
to
843f5c7
Compare
@nitishchauhan0022 You must exec make build & make manifests, and push again. |
@zmberg I did it before pushing, and I tried again now, but no changes were observed. |
@@ -403,6 +403,9 @@ func (ssc *defaultStatefulSetControl) updateStatefulSet( | |||
status.ReadyReplicas++ | |||
if getPodRevision(pods[i]) == updateRevision.Name { | |||
status.UpdatedReadyReplicas++ | |||
if avail, _ := isRunningAndAvailable(pods[i], minReadySeconds); avail { | |||
status.UpdatedAvailableReplicas++ | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File have many checks for set.Status.UpdatedReplicas, and i think you can add UpdatedAvailableReplicas checks.
What is your go version? Preferably 1.18. |
1.20.5 |
@nitishchauhan0022 Can you join kruise dingding to communicate with me? |
Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com>
Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com>
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zmberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* adding updatedAvailableReplicas field Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com> * resolving linting error and some check for updatedavailabel replica Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com> * fixing typo Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com> --------- Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com>
* adding updatedAvailableReplicas field Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com> * resolving linting error and some check for updatedavailabel replica Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com> * fixing typo Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com> --------- Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com>
* adding updatedAvailableReplicas field * resolving linting error and some check for updatedavailabel replica * fixing typo ---------
Ⅰ. Describe what this PR does
Added
updatedAvailableReplicas
field to CloneSet and Advanced StatefulSetⅡ. Does this pull request fix one issue?
fixes #1305