-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLCC] SidecarSet support pre-download image #1318
Conversation
Welcome @Hanmengnan! It looks like this is your first PR to openkruise/kruise 🎉 |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1318 +/- ##
==========================================
- Coverage 48.28% 48.04% -0.25%
==========================================
Files 152 153 +1
Lines 21469 21619 +150
==========================================
+ Hits 10366 10386 +20
- Misses 9969 10093 +124
- Partials 1134 1140 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
277d2a3
to
911535d
Compare
@Hanmengnan Can you join kruise dingding group to communicate with me? |
Sure, I have joined kruise dingding group, can you tell me your name in the groupso that I can contact you. |
立衡 |
/lgtm |
@cubxxw: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
a407061
to
8daf6de
Compare
1b8958f
to
27458db
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I have add the |
d995217
to
93af365
Compare
Signed-off-by: Hanmengnan <1448189829@qq.com>
Signed-off-by: Hanmengnan <1448189829@qq.com>
Signed-off-by: Hanmengnan <1448189829@qq.com>
Signed-off-by: Hanmengnan <1448189829@qq.com>
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Ⅰ. Describe what this PR does
Add the feature that SidecarSet support pre-download image.
The SidecarSet controller will automatically pre download your new version image on all nodes where the old version pod is located. It will be very helpful for accelerating application release.
The following situations will skip image pre downloading:
The parallelism of each new image pre-downloading by SidecarSet is 1, which means the image is downloaded on nodes one by one. You can change the parallelism using
apps.kruise.io/image-predownload-parallelism
annotation on SidecarSet according to the capability of image registry.Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews