Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLCC] SidecarSet support pre-download image #1318

Closed
wants to merge 4 commits into from

Conversation

Hanmengnan
Copy link

Ⅰ. Describe what this PR does

Add the feature that SidecarSet support pre-download image.

The SidecarSet controller will automatically pre download your new version image on all nodes where the old version pod is located. It will be very helpful for accelerating application release.

The following situations will skip image pre downloading:

  1. ignore if update type is NotUpdate
  2. ignore if all Pods update in one batch

The parallelism of each new image pre-downloading by SidecarSet is 1, which means the image is downloaded on nodes one by one. You can change the parallelism using apps.kruise.io/image-predownload-parallelism annotation on SidecarSet according to the capability of image registry.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot
Copy link

Welcome @Hanmengnan! It looks like this is your first PR to openkruise/kruise 🎉

@kruise-bot kruise-bot added the size/L size/L: 100-499 label Jun 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2023

Codecov Report

Merging #1318 (b066b1b) into master (e6205a5) will decrease coverage by 0.25%.
The diff coverage is 19.87%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1318      +/-   ##
==========================================
- Coverage   48.28%   48.04%   -0.25%     
==========================================
  Files         152      153       +1     
  Lines       21469    21619     +150     
==========================================
+ Hits        10366    10386      +20     
- Misses       9969    10093     +124     
- Partials     1134     1140       +6     
Flag Coverage Δ
unittests 48.04% <19.87%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...troller/sidecarset/sidecarset_predownload_image.go 11.92% <11.92%> (ø)
pkg/controller/sidecarset/sidecarset_controller.go 13.79% <14.28%> (-1.60%) ⬇️
pkg/controller/sidecarset/sidecarset_processor.go 66.13% <40.00%> (-1.95%) ⬇️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zmberg
Copy link
Member

zmberg commented Jun 25, 2023

#1221

@Hanmengnan Hanmengnan force-pushed the issue-1221 branch 2 times, most recently from 277d2a3 to 911535d Compare July 1, 2023 10:33
@zmberg
Copy link
Member

zmberg commented Jul 4, 2023

@Hanmengnan Can you join kruise dingding group to communicate with me?

pkg/controller/util/image.go Outdated Show resolved Hide resolved
pkg/controller/sidecarset/sidecarset_controller.go Outdated Show resolved Hide resolved
@Hanmengnan
Copy link
Author

@Hanmengnan Can you join kruise dingding group to communicate with me?

Sure, I have joined kruise dingding group, can you tell me your name in the groupso that I can contact you.

@zmberg
Copy link
Member

zmberg commented Jul 5, 2023

@Hanmengnan Can you join kruise dingding group to communicate with me?

Sure, I have joined kruise dingding group, can you tell me your name in the groupso that I can contact you.

立衡

@zmberg zmberg changed the title Feat: SidecarSet support pre-download image [GLCC] SidecarSet support pre-download image Jul 5, 2023
@cubxxw
Copy link

cubxxw commented Jul 5, 2023

/lgtm

@kruise-bot
Copy link

@cubxxw: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Hanmengnan Hanmengnan force-pushed the issue-1221 branch 6 times, most recently from 1b8958f to 27458db Compare July 22, 2023 09:20
@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign furykerry for approval by writing /assign @furykerry in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Hanmengnan
Copy link
Author

I have add the apps.kruise.io/image-predownload-min-updated-ready-pods to make sure the new image starting pre-download after a few new Pods have been updated ready.

Signed-off-by: Hanmengnan <1448189829@qq.com>
Signed-off-by: Hanmengnan <1448189829@qq.com>
Signed-off-by: Hanmengnan <1448189829@qq.com>
Signed-off-by: Hanmengnan <1448189829@qq.com>
Copy link

stale bot commented Nov 20, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Nov 20, 2023
@stale stale bot closed this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L size/L: 100-499 wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants