cloneset ignore maxSurge when UpdateStrategyPaused=true #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pingjaing <xiangpingjiang1998@gmail.com>
zmberg
reviewed
Jun 30, 2023
Signed-off-by: pingjaing <xiangpingjiang1998@gmail.com>
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1324 +/- ##
=======================================
Coverage 48.54% 48.54%
=======================================
Files 152 152
Lines 21240 21249 +9
=======================================
+ Hits 10310 10316 +6
- Misses 9801 9803 +2
- Partials 1129 1130 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@xiangpingjiang And you can add the following UT: |
|
@xiangpingjiang Plz add these UTs {
name: "[UpdateStrategyPaused=true] create 0 newRevision pods with maxSurge=3,maxUnavailable=0",
set: setUpdateStrategyPaused(createTestCloneSet(5, intstr.FromInt(0), intstr.FromInt(0), intstr.FromInt(3)), true),
pods: []*v1.Pod{
createTestPod(oldRevision, appspub.LifecycleStateNormal, true, false),
createTestPod(oldRevision, appspub.LifecycleStateNormal, true, false),
createTestPod(oldRevision, appspub.LifecycleStateNormal, true, false),
createTestPod(oldRevision, appspub.LifecycleStateNormal, true, false),
createTestPod(oldRevision, appspub.LifecycleStateNormal, true, false),
createTestPod(newRevision, appspub.LifecycleStateNormal, false, false),
createTestPod(newRevision, appspub.LifecycleStateNormal, false, false),
createTestPod(newRevision, appspub.LifecycleStateNormal, false, false),
},
expectResult: expectationDiffs{scaleDownNum: 3, scaleDownNumOldRevision: 5, updateNum: 2, updateMaxUnavailable: 3},
},
{
name: "[UpdateStrategyPaused=true] create 0 newRevision pods with maxSurge=3,maxUnavailable=0",
set: setUpdateStrategyPaused(createTestCloneSet(5, intstr.FromInt(2), intstr.FromInt(0), intstr.FromInt(3)), true),
pods: []*v1.Pod{
createTestPod(oldRevision, appspub.LifecycleStateNormal, true, false),
createTestPod(oldRevision, appspub.LifecycleStateNormal, true, false),
createTestPod(oldRevision, appspub.LifecycleStateNormal, true, false),
createTestPod(oldRevision, appspub.LifecycleStateNormal, true, false),
createTestPod(oldRevision, appspub.LifecycleStateNormal, true, false),
createTestPod(newRevision, appspub.LifecycleStateNormal, false, false),
createTestPod(newRevision, appspub.LifecycleStateNormal, false, false),
createTestPod(newRevision, appspub.LifecycleStateNormal, false, false),
},
expectResult: expectationDiffs{scaleDownNum: 3, scaleDownNumOldRevision: 3},
}, |
Signed-off-by: pingjiang <xiangpingjiang1998@gmail.com>
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zmberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
diannaowa
pushed a commit
to diannaowa/kruise
that referenced
this pull request
Aug 29, 2023
) * cloneset ignore maxSurge when UpdateStrategyPaused=true Signed-off-by: pingjaing <xiangpingjiang1998@gmail.com> * add scale down UT case for cloneSet UpdateStrategyPaused=true Signed-off-by: pingjaing <xiangpingjiang1998@gmail.com> * add UTs for cloneSet when UpdateStrategyPaused=true Signed-off-by: pingjiang <xiangpingjiang1998@gmail.com> --------- Signed-off-by: pingjaing <xiangpingjiang1998@gmail.com> Signed-off-by: pingjiang <xiangpingjiang1998@gmail.com>
lilongfeng0902
pushed a commit
to lilongfeng0902/kruise
that referenced
this pull request
Sep 12, 2023
) * cloneset ignore maxSurge when UpdateStrategyPaused=true Signed-off-by: pingjaing <xiangpingjiang1998@gmail.com> * add scale down UT case for cloneSet UpdateStrategyPaused=true Signed-off-by: pingjaing <xiangpingjiang1998@gmail.com> * add UTs for cloneSet when UpdateStrategyPaused=true Signed-off-by: pingjiang <xiangpingjiang1998@gmail.com> --------- Signed-off-by: pingjaing <xiangpingjiang1998@gmail.com> Signed-off-by: pingjiang <xiangpingjiang1998@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
fixes #1153
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews