feat: SidecarSet updateStrategy support priorityStrategy #1325
Conversation
y-ykcir
force-pushed
the
feat-sidecarset-us
branch
from
ce0b6c4 to
753d061
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1325 +/- ##
=======================================
Coverage 48.54% 48.54%
=======================================
Files 152 152
Lines 21240 21246 +6
=======================================
+ Hits 10310 10313 +3
- Misses 9801 9803 +2
- Partials 1129 1130 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: ricky <yricky509@gmail.com>
y-ykcir
force-pushed
the
feat-sidecarset-us
branch
from
753d061 to
4be2873
Compare
|
@y-ykcir Can you add some UT for this feature? |
Signed-off-by: ricky <yricky509@gmail.com>
|
@zmberg done PTAL. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zmberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…1325) * feat: SidecarSet updateStrategy support priorityStrategy Signed-off-by: ricky <yricky509@gmail.com> * add ut for sidecarset priority strategy Signed-off-by: ricky <yricky509@gmail.com> --------- Signed-off-by: ricky <yricky509@gmail.com>
…1325) * feat: SidecarSet updateStrategy support priorityStrategy Signed-off-by: ricky <yricky509@gmail.com> * add ut for sidecarset priority strategy Signed-off-by: ricky <yricky509@gmail.com> --------- Signed-off-by: ricky <yricky509@gmail.com>
…1325) * feat: SidecarSet updateStrategy support priorityStrategy * add ut for sidecarset priority strategy ---------
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
fixed #1313
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews