Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support parameter set CacheSyncTimeout for controller #1329

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

zmberg
Copy link
Member

@zmberg zmberg commented Jul 7, 2023

Ⅰ. Describe what this PR does

support parameter set CacheSyncTimeout for controller

@kruise-bot kruise-bot added the size/M size/M: 30-99 label Jul 7, 2023
@@ -415,7 +415,7 @@
}

func (r *ReconcilePodUnavailableBudget) buildDisruptedAndUnavailablePods(pods []*corev1.Pod, pub *policyv1alpha1.PodUnavailableBudget, currentTime time.Time) (
// disruptedPods, unavailablePods, recheckTime
// disruptedPods, unavailablePods, recheckTime
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

39% of developers fix this issue

gofmt: File is not gofmt-ed with -s


ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.

@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2023

Codecov Report

Merging #1329 (7a07c41) into master (24a4b7f) will increase coverage by 0.05%.
The diff coverage is 8.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1329      +/-   ##
==========================================
+ Coverage   48.56%   48.61%   +0.05%     
==========================================
  Files         152      152              
  Lines       21255    21328      +73     
==========================================
+ Hits        10322    10369      +47     
- Misses       9803     9823      +20     
- Partials     1130     1136       +6     
Flag Coverage Δ
unittests 48.61% <8.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ller/advancedcronjob/advancedcronjob_controller.go 31.76% <0.00%> (-0.38%) ⬇️
...controller/broadcastjob/broadcastjob_controller.go 55.57% <0.00%> (ø)
...chpriority/container_launch_priority_controller.go 34.51% <0.00%> (-0.31%) ⬇️
pkg/controller/daemonset/daemonset_controller.go 41.60% <0.00%> (ø)
...er/imagelistpulljob/imagelistpulljob_controller.go 61.30% <0.00%> (-0.24%) ⬇️
...ntroller/nodepodprobe/node_pod_probe_controller.go 58.97% <0.00%> (ø)
...sistentpodstate/persistent_pod_state_controller.go 31.18% <0.00%> (ø)
...ller/podprobemarker/pod_probe_marker_controller.go 52.68% <0.00%> (ø)
...ontroller/podreadiness/pod_readiness_controller.go 28.35% <0.00%> (-0.43%) ⬇️
...availablebudget/podunavailablebudget_controller.go 46.60% <0.00%> (ø)
... and 8 more

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@zmberg
Copy link
Member Author

zmberg commented Jul 10, 2023

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 6ec9dee into openkruise:master Jul 10, 2023
21 checks passed
@zmberg zmberg deleted the cache_sync_timeout branch August 22, 2023 02:49
diannaowa pushed a commit to diannaowa/kruise that referenced this pull request Aug 29, 2023
Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
lilongfeng0902 pushed a commit to lilongfeng0902/kruise that referenced this pull request Sep 12, 2023
Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants