fix 1337 support cri-dockered runtime #1338
Conversation
Sonatype Lift is retiringSonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. |
|
Welcome @beastpu! It looks like this is your first PR to openkruise/kruise 🎉 |
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
pkg/daemon/criruntime/factory.go
Outdated
| } | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
gofmt: File is not gofmt-ed with -s
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1338 +/- ##
==========================================
+ Coverage 48.60% 50.36% +1.76%
==========================================
Files 152 154 +2
Lines 21333 22740 +1407
==========================================
+ Hits 10369 11454 +1085
- Misses 9828 10104 +276
- Partials 1136 1182 +46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
beastpu
force-pushed
the
fix-issue-cri-dockerd-support
branch
2 times, most recently
from
97e8eef
to
29c97dc
Compare
Signed-off-by: beast <beastpu@lilith.com>
beastpu
force-pushed
the
fix-issue-cri-dockerd-support
branch
from
29c97dc
to
dcfd580
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hantmac The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
please review @veophi |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Ⅰ. Describe what this PR does
fix #1337
This modification adds support for the cri-dockered runtime in addition to the existing dockershim runtimes.
It checks for the existence of each socket and appends the appropriate configuration to cfgs based on the combination of sockets found. If none of the sockets are found, an error message indicating the missing sockets is logged.