Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump K8s dependency to 1.24.16, golang vesion 1.19 #1354

Merged
merged 3 commits into from
Aug 8, 2023

Conversation

Kuromesi
Copy link
Contributor

@Kuromesi Kuromesi commented Aug 2, 2023

Ⅰ. Describe what this PR does

Bump K8s dependency to 1.24, golang vesion 1.19.x

Ⅱ. Does this pull request fix one issue?

#1296

@sonatype-lift
Copy link

sonatype-lift bot commented Aug 2, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@kruise-bot kruise-bot requested review from Fei-Guo and furykerry August 2, 2023 08:45
@kruise-bot
Copy link

Welcome @Kuromesi! It looks like this is your first PR to openkruise/kruise 🎉

Signed-off-by: Kuromesi <blackfacepan@163.com>
Signed-off-by: Kuromesi <blackfacepan@163.com>
@Kuromesi Kuromesi force-pushed the master branch 3 times, most recently from 9661049 to c12d897 Compare August 7, 2023 07:22
@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2023

Codecov Report

Merging #1354 (15ed547) into master (76f45ac) will decrease coverage by 0.38%.
Report is 2 commits behind head on master.
The diff coverage is 31.71%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1354      +/-   ##
==========================================
- Coverage   48.57%   48.20%   -0.38%     
==========================================
  Files         152      152              
  Lines       21333    21465     +132     
==========================================
- Hits        10363    10347      -16     
- Misses       9832     9977     +145     
- Partials     1138     1141       +3     
Flag Coverage Δ
unittests 48.20% <31.71%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...troller/statefulset/stateful_set_status_updater.go 82.35% <ø> (ø)
pkg/controller/statefulset/stateful_set_utils.go 81.37% <0.00%> (-0.55%) ⬇️
pkg/daemon/criruntime/imageruntime/containerd.go 0.00% <0.00%> (ø)
pkg/daemon/criruntime/imageruntime/cri.go 0.00% <0.00%> (ø)
pkg/daemon/criruntime/imageruntime/helpers.go 19.16% <0.00%> (-3.17%) ⬇️
pkg/daemon/podprobe/pod_probe_controller.go 41.90% <0.00%> (ø)
pkg/daemon/podprobe/prober.go 0.00% <ø> (ø)
pkg/controller/daemonset/daemonset_history.go 32.99% <30.00%> (-1.04%) ⬇️
pkg/controller/statefulset/stateful_set_control.go 62.62% <78.12%> (-0.81%) ⬇️
pkg/controller/daemonset/daemonset_controller.go 41.60% <78.37%> (ø)
... and 7 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@veophi
Copy link
Member

veophi commented Aug 7, 2023

/LGTM

Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>

update cloneset ut for go 1.19

Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
@veophi
Copy link
Member

veophi commented Aug 8, 2023

/LGTM

@kruise-bot kruise-bot added the lgtm label Aug 8, 2023
@veophi
Copy link
Member

veophi commented Aug 8, 2023

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: veophi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 6d18d2e into openkruise:master Aug 8, 2023
diannaowa pushed a commit to diannaowa/kruise that referenced this pull request Aug 29, 2023
* Bump K8s dependency to 1.24.16, golang to 1.19

Signed-off-by: Kuromesi <blackfacepan@163.com>

* update daemonset and statefulset to 1.24.16

Signed-off-by: Kuromesi <blackfacepan@163.com>

* compatible with v1 and v1alpha2 cri api version

Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>

update cloneset ut for go 1.19

Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>

---------

Signed-off-by: Kuromesi <blackfacepan@163.com>
Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
* Bump K8s dependency to 1.24.16, golang to 1.19


* update daemonset and statefulset to 1.24.16


* compatible with v1 and v1alpha2 cri api version


update cloneset ut for go 1.19


---------

Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants