Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add imagepulljob featuregate #1357

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

zmberg
Copy link
Member

@zmberg zmberg commented Aug 3, 2023

Ⅰ. Describe what this PR does

Add featuregate for ImagePullJob.

@sonatype-lift
Copy link

sonatype-lift bot commented Aug 3, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@kruise-bot kruise-bot requested review from furykerry and veophi August 3, 2023 12:12
@kruise-bot kruise-bot added the size/S size/S 10-29 label Aug 3, 2023
Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
@zmberg zmberg force-pushed the imagepulljob_featuregate branch from ca4c28b to 22b6068 Compare August 3, 2023 12:19
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2023

Codecov Report

Merging #1357 (22b6068) into master (a44ca54) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1357      +/-   ##
==========================================
- Coverage   48.57%   48.57%   -0.01%     
==========================================
  Files         152      152              
  Lines       21333    21334       +1     
==========================================
  Hits        10363    10363              
- Misses       9832     9833       +1     
  Partials     1138     1138              
Flag Coverage Δ
unittests 48.57% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...er/imagelistpulljob/imagelistpulljob_controller.go 61.06% <0.00%> (-0.24%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kruise-bot kruise-bot added size/M size/M: 30-99 and removed size/S size/S 10-29 labels Aug 7, 2023
@zmberg zmberg force-pushed the imagepulljob_featuregate branch from 13a11a3 to 040b7e8 Compare August 7, 2023 08:09
Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
@zmberg zmberg force-pushed the imagepulljob_featuregate branch from 040b7e8 to 4146dd0 Compare August 7, 2023 08:13
@veophi
Copy link
Member

veophi commented Aug 7, 2023

/lgtm

@zmberg
Copy link
Member Author

zmberg commented Aug 8, 2023

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 21c0846 into openkruise:master Aug 8, 2023
diannaowa pushed a commit to diannaowa/kruise that referenced this pull request Aug 29, 2023
* add imagepulljob featuregate

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>

* add e2e for imagepulljob secret

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>

---------

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
lilongfeng0902 pushed a commit to lilongfeng0902/kruise that referenced this pull request Sep 12, 2023
* add imagepulljob featuregate

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>

* add e2e for imagepulljob secret

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>

---------

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
* add imagepulljob featuregate


* add e2e for imagepulljob secret


---------
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants