Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add resourcesdistribution featuregate #1360

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

zmberg
Copy link
Member

@zmberg zmberg commented Aug 9, 2023

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@sonatype-lift
Copy link

sonatype-lift bot commented Aug 9, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@kruise-bot kruise-bot requested review from FillZpp and veophi August 9, 2023 09:43
@kruise-bot kruise-bot added the size/M size/M: 30-99 label Aug 9, 2023
@veophi
Copy link
Member

veophi commented Aug 9, 2023

/lgtm

@@ -15,7 +15,9 @@

import (
"context"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

21% of developers fix this issue

goimports: File is not goimports-ed


ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
@zmberg zmberg force-pushed the resourcedistribution-gate branch from 3abd912 to f5702f1 Compare August 9, 2023 09:54
@kruise-bot kruise-bot removed the lgtm label Aug 9, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1360 (3abd912) into master (6d18d2e) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 3abd912 differs from pull request most recent head f5702f1. Consider uploading reports for the commit f5702f1 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1360      +/-   ##
==========================================
- Coverage   48.25%   48.25%   -0.01%     
==========================================
  Files         152      152              
  Lines       21466    21469       +3     
==========================================
  Hits        10359    10359              
- Misses       9970     9973       +3     
  Partials     1137     1137              
Flag Coverage Δ
unittests 48.25% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rcedistribution/resourcedistribution_controller.go 27.42% <0.00%> (ø)
...ting/resourcedistribution_create_update_handler.go 60.91% <0.00%> (-2.18%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@veophi
Copy link
Member

veophi commented Aug 10, 2023

/lgtm

@veophi
Copy link
Member

veophi commented Aug 10, 2023

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: veophi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 321c991 into openkruise:master Aug 10, 2023
diannaowa pushed a commit to diannaowa/kruise that referenced this pull request Aug 29, 2023
Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
lilongfeng0902 pushed a commit to lilongfeng0902/kruise that referenced this pull request Sep 12, 2023
Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants